Re: [PATCH] clocksource: whitelist asm9260_timer driver for ARM

Guenter Roeck
2015-02-18T07:17:59Z

On 02/10/2015 07:57 AM, Oleksij Rempel wrote:
> For now it is easier to allow only tested platforms, instead of
> fighting with different platform specific issues.
>
> This patch is fixing compile error on ARCH=SPARC and SPARC64:
>
> Building sparc64:allmodconfig ... failed
> --------------
> Error log:
> drivers/built-in.o: In function `asm9260_timer_init':
> asm9260_timer.c:(.init.text+0x60d4): undefined reference to `of_io_request_and_map'
>
> Tested-by: Guenter Roeck <linux@roeck-us.net>
> Reported-by: Guenter Roeck <linux@roeck-us.net>
> Signed-off-by: Oleksij Rempel <linux@rempel-privat.de>

The problem solved by this patch has affected linux-next
for almost a month, the problem is now in mainline, yet
I have not seen feedback from anyone about it.

Did the patch get lost, or is there some problem with it ?

Thanks,
Guenter

> ---
> drivers/clocksource/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
> index bfaaae4..39d5c11 100644
> --- a/drivers/clocksource/Kconfig
> +++ b/drivers/clocksource/Kconfig
> @@ -231,7 +231,7 @@ config CLKSRC_MIPS_GIC
>
> config ASM9260_TIMER
> bool "Alphascale ASM9260 timer driver"
> - depends on GENERIC_CLOCKEVENTS
> + depends on GENERIC_CLOCKEVENTS && ARM
> select CLKSRC_MMIO
> select CLKSRC_OF
> default y if MACH_ASM9260
>