From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752411AbbBRJ7W (ORCPT ); Wed, 18 Feb 2015 04:59:22 -0500 Received: from cantor2.suse.de ([195.135.220.15]:46608 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752223AbbBRJ7U (ORCPT ); Wed, 18 Feb 2015 04:59:20 -0500 Message-ID: <54E46276.1080205@suse.com> Date: Wed, 18 Feb 2015 10:59:18 +0100 From: Juergen Gross User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Jan Beulich CC: david.vrabel@citrix.com, xen-devel@lists.xensource.com, boris.ostrovsky@oracle.com, Paul Bolle , linux-kernel@vger.kernel.org Subject: Re: [Xen-devel] [PATCH 13/13] xen: allow more than 512 GB of RAM for 64 bit pv-domains References: <1424242326-26611-1-git-send-email-jgross@suse.com> <1424242326-26611-14-git-send-email-jgross@suse.com> <1424251292.7082.72.camel@x220> <54E45D6D.3050900@suse.com> <54E46E3C0200007800060F98@suse.com> In-Reply-To: <54E46E3C0200007800060F98@suse.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/18/2015 10:49 AM, Jan Beulich wrote: >>>> On 18.02.15 at 10:37, wrote: >> On 02/18/2015 10:21 AM, Paul Bolle wrote: >>> On Wed, 2015-02-18 at 07:52 +0100, Juergen Gross wrote: >>>> --- a/arch/x86/xen/Kconfig >>>> +++ b/arch/x86/xen/Kconfig >>>> @@ -23,14 +23,29 @@ config XEN_PVHVM >>>> def_bool y >>>> depends on XEN && PCI && X86_LOCAL_APIC >>>> >>>> -config XEN_MAX_DOMAIN_MEMORY >>>> - int >>>> - default 500 if X86_64 >>>> - default 64 if X86_32 >>>> - depends on XEN >>>> - help >>>> - This only affects the sizing of some bss arrays, the unused >>>> - portions of which are freed. >>>> +if X86_64 >>> >>> Not >>> && XEN >>> ? >> >> The complete directory is made only if CONFIG_XEN is set. > > But that doesn't mean this file gets used only when XEN is enabled. Oh, you are right. I seem to have mixed up make and Kconfig of the directory. > I would think though that an eventual "if XEN" should have wider > scope than just this option (i.e. likely almost the entire file). Indeed. So either I'll add the XEN dependency for the new option or I do another patch adding "if XEN" just below configuring XEN and remove the XEN dependencies in the rest of the entries. As Luis is just doing a rework of XEN Kconfig stuff, I think I'll add the XEN dependency. Juergen