From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751768AbbBRMlT (ORCPT ); Wed, 18 Feb 2015 07:41:19 -0500 Received: from mailout3.w1.samsung.com ([210.118.77.13]:28807 "EHLO mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750978AbbBRMlS (ORCPT ); Wed, 18 Feb 2015 07:41:18 -0500 MIME-version: 1.0 Content-type: text/plain; charset=utf-8 X-AuditID: cbfec7f4-b7f126d000001e9a-73-54e487daa964 Content-transfer-encoding: 8BIT Message-id: <54E4886A.5080902@samsung.com> Date: Wed, 18 Feb 2015 13:41:14 +0100 From: Karol Wrona User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 To: Geert Uytterhoeven , Jonathan Cameron , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] iio: common: ssp_sensors: Protect PM-only functions to kill warning References: <1424259586-29334-1-git-send-email-geert@linux-m68k.org> In-reply-to: <1424259586-29334-1-git-send-email-geert@linux-m68k.org> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrLLMWRmVeSWpSXmKPExsVy+t/xq7q32p+EGMx9x2jx7NZeJosHTauY LHb9f8NssWTyfFaLeUfesVhc3jWHzeL3rmPsDuweHz7GeWxa1cnmcehwB6PHkjeHWD3ONx9h 9Pi8SS6ALYrLJiU1J7MstUjfLoErY/3k36wFW7kqThxZyt7AeIyji5GDQ0LARGLrP8EuRk4g U0ziwr31bF2MXBxCAksZJfb1bGIESfAKCEr8mHyPBaSeWUBe4silbAhTXWLKlFyI8k+MEs9f 9rJClGtJ/H1wH6ycRUBV4uq3WJAwG1B5847FzCC2qECExPxjr5lBekUEDjFKfOnbxA6SYBaw lrixfhUTiC0sECvx+P1jsAYhAReJTbcugp3DKeAqcfnNJpYJjAKzkFw3C+G6WQjXLWBkXsUo mlqaXFCclJ5rqFecmFtcmpeul5yfu4kREuRfdjAuPmZ1iFGAg1GJhzdg6aMQIdbEsuLKXKC7 OJiVRHjj45+ECPGmJFZWpRblxxeV5qQWH2Jk4uCUamDM0ghmi796v4hVIWfJnnfi1daut7xX +nLNPdHttH5dZlCW7ZEv9raZb+QCfP0uvtUxPc3CF3b76dQn/pHmstHyjYsuqBd6Fa/87PN+ 0oSTDyV3v7kWxOzYcOd3gsyOvpq4Q8+tHyRanA7aWTDhS1XrKpF2XoFL+2+kfm7K73mabm2m KfDsgpcSS3FGoqEWc1FxIgCdSiVIUAIAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/18/2015 12:39 PM, Geert Uytterhoeven wrote: > If CONFIG_PM_SLEEP=n: > > drivers/iio/common/ssp_sensors/ssp_dev.c:644: warning: ‘ssp_suspend’ defined but not used > drivers/iio/common/ssp_sensors/ssp_dev.c:669: warning: ‘ssp_resume’ defined but not used > > Protect the unused functions by #ifdef CONFIG_PM_SLEEP to fix this. > > Signed-off-by: Geert Uytterhoeven > --- > v2: > - Fix driver name in one-line summary > --- > drivers/iio/common/ssp_sensors/ssp_dev.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/iio/common/ssp_sensors/ssp_dev.c b/drivers/iio/common/ssp_sensors/ssp_dev.c > index 52d70435f5a11c55..55a90082a29bd484 100644 > --- a/drivers/iio/common/ssp_sensors/ssp_dev.c > +++ b/drivers/iio/common/ssp_sensors/ssp_dev.c > @@ -640,6 +640,7 @@ static int ssp_remove(struct spi_device *spi) > return 0; > } > > +#ifdef CONFIG_PM_SLEEP > static int ssp_suspend(struct device *dev) > { > int ret; > @@ -688,6 +689,7 @@ static int ssp_resume(struct device *dev) > > return 0; > } > +#endif /* CONFIG_PM_SLEEP */ > > static const struct dev_pm_ops ssp_pm_ops = { > SET_SYSTEM_SLEEP_PM_OPS(ssp_suspend, ssp_resume) > Acked-by: Karol Wrona Thanks for doing that. Karol