Re: [Patch v2] firmware: dmi_scan: fix dmi scan to handle "End of Table" structure

[Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org>]

Ok, I'll correct commit msg like:

But after adding initial SMBIOS v3 support (fc43026278b23b3515cf8f909ec29df94b3ae1a2)
the 127-0 entry is nothandled any more, as result it's not created in sysfs.


On 02/18/2015 03:04 PM, Matt Fleming wrote:
> On Wed, 04 Feb, at 04:22:05PM, Ivan Khoronzhuk wrote:
>> The dmi-sysfs should create "End of Table" entry, that is type 127.
>> But after adding initial SMBIOS v3 support the 127-0 entry is not
>> handled any more, as result it's not created in sysfs.
>> This is important because the size of whole DMI table must correspond
>> to sum of all DMI entry sizes.
>>
>> So move "end-of-table" check after it's handled by decode.
>>
>> Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org>
>> ---
>>
>> v2..v1:
>> 	Move end of table check after it's handled instead of removing
>> 	Correct commit
>>
>>   drivers/firmware/dmi_scan.c | 13 +++++++------
>>   1 file changed, 7 insertions(+), 6 deletions(-)
> The way that the commit log is written makes this sound like a
> regression. If that's the case, then you need to list which commit
> introduced the regression, because that will tell me whether it needs
> tagging for stable.
>