From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753485AbbBRR5G (ORCPT ); Wed, 18 Feb 2015 12:57:06 -0500 Received: from mail-ob0-f176.google.com ([209.85.214.176]:56825 "EHLO mail-ob0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753344AbbBRR5E (ORCPT ); Wed, 18 Feb 2015 12:57:04 -0500 Message-ID: <54E4D26B.6020509@acm.org> Date: Wed, 18 Feb 2015 11:56:59 -0600 From: Corey Minyard Reply-To: minyard@acm.org User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: Joe Perches CC: openipmi-developer@lists.sourceforge.net, LKML Subject: Re: [PATCH] ipmi: Remove uses of return value of seq_printf References: <1424200256.25416.3.camel@perches.com> In-Reply-To: <1424200256.25416.3.camel@perches.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Thanks, queued for 3.20. -corey On 02/17/2015 01:10 PM, Joe Perches wrote: > The seq_printf like functions will soon be changed to return void. > > Convert these uses to check seq_has_overflowed instead. > > Signed-off-by: Joe Perches > --- > drivers/char/ipmi/ipmi_msghandler.c | 12 ++++++++---- > drivers/char/ipmi/ipmi_si_intf.c | 26 +++++++++++++++----------- > drivers/char/ipmi/ipmi_ssif.c | 4 +++- > 3 files changed, 26 insertions(+), 16 deletions(-) > > diff --git a/drivers/char/ipmi/ipmi_msghandler.c b/drivers/char/ipmi/ipmi_msghandler.c > index bf95efc..fa0b941 100644 > --- a/drivers/char/ipmi/ipmi_msghandler.c > +++ b/drivers/char/ipmi/ipmi_msghandler.c > @@ -1997,7 +1997,9 @@ static int smi_ipmb_proc_show(struct seq_file *m, void *v) > seq_printf(m, "%x", intf->channels[0].address); > for (i = 1; i < IPMI_MAX_CHANNELS; i++) > seq_printf(m, " %x", intf->channels[i].address); > - return seq_putc(m, '\n'); > + seq_putc(m, '\n'); > + > + return seq_has_overflowed(m); > } > > static int smi_ipmb_proc_open(struct inode *inode, struct file *file) > @@ -2016,9 +2018,11 @@ static int smi_version_proc_show(struct seq_file *m, void *v) > { > ipmi_smi_t intf = m->private; > > - return seq_printf(m, "%u.%u\n", > - ipmi_version_major(&intf->bmc->id), > - ipmi_version_minor(&intf->bmc->id)); > + seq_printf(m, "%u.%u\n", > + ipmi_version_major(&intf->bmc->id), > + ipmi_version_minor(&intf->bmc->id)); > + > + return seq_has_overflowed(m); > } > > static int smi_version_proc_open(struct inode *inode, struct file *file) > diff --git a/drivers/char/ipmi/ipmi_si_intf.c b/drivers/char/ipmi/ipmi_si_intf.c > index fd6110f..321ecb2 100644 > --- a/drivers/char/ipmi/ipmi_si_intf.c > +++ b/drivers/char/ipmi/ipmi_si_intf.c > @@ -2979,7 +2979,9 @@ static int smi_type_proc_show(struct seq_file *m, void *v) > { > struct smi_info *smi = m->private; > > - return seq_printf(m, "%s\n", si_to_str[smi->si_type]); > + seq_printf(m, "%s\n", si_to_str[smi->si_type]); > + > + return seq_has_overflowed(m); > } > > static int smi_type_proc_open(struct inode *inode, struct file *file) > @@ -3041,16 +3043,18 @@ static int smi_params_proc_show(struct seq_file *m, void *v) > { > struct smi_info *smi = m->private; > > - return seq_printf(m, > - "%s,%s,0x%lx,rsp=%d,rsi=%d,rsh=%d,irq=%d,ipmb=%d\n", > - si_to_str[smi->si_type], > - addr_space_to_str[smi->io.addr_type], > - smi->io.addr_data, > - smi->io.regspacing, > - smi->io.regsize, > - smi->io.regshift, > - smi->irq, > - smi->slave_addr); > + seq_printf(m, > + "%s,%s,0x%lx,rsp=%d,rsi=%d,rsh=%d,irq=%d,ipmb=%d\n", > + si_to_str[smi->si_type], > + addr_space_to_str[smi->io.addr_type], > + smi->io.addr_data, > + smi->io.regspacing, > + smi->io.regsize, > + smi->io.regshift, > + smi->irq, > + smi->slave_addr); > + > + return seq_has_overflowed(m); > } > > static int smi_params_proc_open(struct inode *inode, struct file *file) > diff --git a/drivers/char/ipmi/ipmi_ssif.c b/drivers/char/ipmi/ipmi_ssif.c > index 74128e6..f6e378d 100644 > --- a/drivers/char/ipmi/ipmi_ssif.c > +++ b/drivers/char/ipmi/ipmi_ssif.c > @@ -1196,7 +1196,9 @@ static int ssif_detect(struct i2c_client *client, struct i2c_board_info *info) > > static int smi_type_proc_show(struct seq_file *m, void *v) > { > - return seq_puts(m, "ssif\n"); > + seq_puts(m, "ssif\n"); > + > + return seq_has_overflowed(m); > } > > static int smi_type_proc_open(struct inode *inode, struct file *file) > >