public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: David Ahern <dsahern@gmail.com>
To: John Stultz <john.stultz@linaro.org>,
	Stephane Eranian <eranian@google.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	acme@redhat.com, Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@elte.hu>,
	ak@linux.intel.com, Jiri Olsa <jolsa@redhat.com>,
	namhyung@kernel.org, cel@us.ibm.com, sukadev@linux.vnet.ibm.com,
	sonnyrao@chromium.org, johnmccutchan@google.com,
	adrian.hunter@intel.com, pawell.moll@arm.com
Subject: Re: [PATCH v2 4/4] clock: add perf_clock posix clock
Date: Wed, 18 Feb 2015 11:11:16 -0700	[thread overview]
Message-ID: <54E4D5C4.1070005@gmail.com> (raw)
In-Reply-To: <CANcMJZAd=Vmey2sgA4gT8dsa3H4kPXxTGth94tczBS5zQmeQHw@mail.gmail.com>

On 2/18/15 11:00 AM, John Stultz wrote:
> I'd still strongly recommend against exposing the perf clock to
> userspace this way.  The time domain isn't clearly different from
> something like CLOCK_MONOTONIC_RAW and doesn't really have well
> defined behavior. We're just exporting "whatever the kernel does
> internally" to userspace, and in the past similar internal use clocks
> like the sched_clock have changed their behavior, so I'm not confident
> the perf clock is really baked enough (including cross architectures)
> to make it part of the ABI.
>
> Pawel and others have continued to work on other approaches that allow
> for perf events to be interpolated to, or use CLOCK_MONOTONIC itself,
> which I don't object to, so you might want to follow up on those?

AFAIK Stephane is not proposing this patch for inclusion but rather it 
is an unfortunate necessary evil. The module exposes perf_clock (ie., 
local_clock) to userspace and allows in this case the generation of 
samples with a perf timestamp which is required for proper sorting.

I understand this solution is not liked, but it works, requires no 
kernel modifications to achieve the end goal and can be used for kernels 
going back to at least 2.6.38 (perhaps earlier, have not checked).

David


  parent reply	other threads:[~2015-02-18 18:11 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-18 17:21 [PATCH v2 0/4] perf: add support for profiling jitted code Stephane Eranian
2015-02-18 17:21 ` [PATCH v2 1/4] perf tools: add Java demangling support Stephane Eranian
2015-02-18 17:21 ` [PATCH v2 2/4] perf inject: add jitdump mmap injection support Stephane Eranian
2015-02-18 17:21 ` [PATCH v2 3/4] perf tools: add JVMTI agent library Stephane Eranian
2015-02-18 17:21 ` [PATCH v2 4/4] clock: add perf_clock posix clock Stephane Eranian
2015-02-18 17:53   ` Ingo Molnar
2015-02-18 18:00   ` John Stultz
2015-02-18 18:10     ` Stephane Eranian
2015-02-18 18:15       ` John Stultz
2015-02-18 18:11     ` David Ahern [this message]
2015-02-18 18:18       ` John Stultz
2015-02-18 18:21         ` Stephane Eranian
2015-02-18 18:22         ` Ingo Molnar
2015-02-18 19:00   ` Paul Bolle
2015-02-18 19:12   ` Paul Bolle
2015-02-18 17:31 ` [PATCH v2 0/4] perf: add support for profiling jitted code Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54E4D5C4.1070005@gmail.com \
    --to=dsahern@gmail.com \
    --cc=acme@redhat.com \
    --cc=adrian.hunter@intel.com \
    --cc=ak@linux.intel.com \
    --cc=cel@us.ibm.com \
    --cc=eranian@google.com \
    --cc=john.stultz@linaro.org \
    --cc=johnmccutchan@google.com \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=namhyung@kernel.org \
    --cc=pawell.moll@arm.com \
    --cc=peterz@infradead.org \
    --cc=sonnyrao@chromium.org \
    --cc=sukadev@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox