From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753730AbbBRTIv (ORCPT <rfc822;w@1wt.eu>);
	Wed, 18 Feb 2015 14:08:51 -0500
Received: from mail-la0-f50.google.com ([209.85.215.50]:38529 "EHLO
	mail-la0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751730AbbBRTIt (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 18 Feb 2015 14:08:49 -0500
Message-ID: <54E4E33C.9040301@cogentembedded.com>
Date: Wed, 18 Feb 2015 22:08:44 +0300
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Organization: Cogent Embedded
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0
MIME-Version: 1.0
To: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>,
        Sangbeom Kim <sbkim73@samsung.com>, alsa-devel@alsa-project.org,
        linux-samsung-soc@vger.kernel.org
CC: devicetree@vger.kernel.org, Doug Anderson <dianders@chromium.org>,
        Vincent Palatin <vpalatin@chromium.org>,
        Lars-Peter Clausen <lars@metafoo.de>, Takashi Iwai <tiwai@suse.de>,
        Xiubo Li <Li.Xiubo@freescale.com>, Liam Girdwood <lgirdwood@gmail.com>,
        linux-kernel@vger.kernel.org, Mark Brown <broonie@kernel.org>,
        Jaroslav Kysela <perex@perex.cz>, Tomasz Figa <tomasz.figa@gmail.com>,
        Javier Martinez Canillas <javier.martinez@collabora.co.uk>,
        linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/6] ASoC: max98088: Add DT bindings
References: <1424283959-16289-1-git-send-email-afaerber@suse.de> <1424283959-16289-3-git-send-email-afaerber@suse.de>
In-Reply-To: <1424283959-16289-3-git-send-email-afaerber@suse.de>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hello.

On 02/18/2015 09:25 PM, Andreas Färber wrote:

> "maxim,max98089" will be used for the Spring Chromebook.

> Signed-off-by: Andreas Färber <afaerber@suse.de>
> ---
>   sound/soc/codecs/max98088.c | 8 ++++++++
>   1 file changed, 8 insertions(+)

> diff --git a/sound/soc/codecs/max98088.c b/sound/soc/codecs/max98088.c
> index 805b3f8cd39d..69a21d1946e3 100644
> --- a/sound/soc/codecs/max98088.c
> +++ b/sound/soc/codecs/max98088.c
> @@ -2009,10 +2009,18 @@ static const struct i2c_device_id max98088_i2c_id[] = {
>   };
>   MODULE_DEVICE_TABLE(i2c, max98088_i2c_id);
>
> +static const struct of_device_id max98088_of_match[] = {

    If I don't mistake, gcc will complain about this variable being unused if 
CONFIG_OF=n.

> +	{ .compatible = "maxim,max98088" },
> +	{ .compatible = "maxim,max98089" },
> +	{ }
> +};
> +MODULE_DEVICE_TABLE(of, max98088_of_match);
> +
>   static struct i2c_driver max98088_i2c_driver = {
>   	.driver = {
>   		.name = "max98088",
>   		.owner = THIS_MODULE,
> +		.of_match_table = of_match_ptr(max98088_of_match),

    You probably don;t need of_match_ptr(). Either that or do something with 
the match table, like enclosing into #ifdef or annotating with '__maybe_unused'.

[...]

WBR, Sergei