From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932358AbbBSOFY (ORCPT ); Thu, 19 Feb 2015 09:05:24 -0500 Received: from bhuna.collabora.co.uk ([93.93.135.160]:37590 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753169AbbBSOFV (ORCPT ); Thu, 19 Feb 2015 09:05:21 -0500 Message-ID: <54E5ED9A.90802@collabora.co.uk> Date: Thu, 19 Feb 2015 15:05:14 +0100 From: Javier Martinez Canillas User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.2.0 MIME-Version: 1.0 To: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= , Sangbeom Kim , alsa-devel@alsa-project.org, linux-samsung-soc@vger.kernel.org CC: Liam Girdwood , Mark Brown , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Vincent Palatin , Doug Anderson , Tomasz Figa , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Russell King , Kukjin Kim Subject: Re: [PATCH 6/6] ARM: dts: Add sound support to exynos5250-spring References: <1424283959-16289-1-git-send-email-afaerber@suse.de> <1424283959-16289-7-git-send-email-afaerber@suse.de> In-Reply-To: <1424283959-16289-7-git-send-email-afaerber@suse.de> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Andreas, On 02/18/2015 07:25 PM, Andreas Färber wrote: > Signed-off-by: Andreas Färber > --- > arch/arm/boot/dts/exynos5250-spring.dts | 25 +++++++++++++++++++++++++ > 1 file changed, 25 insertions(+) > > diff --git a/arch/arm/boot/dts/exynos5250-spring.dts b/arch/arm/boot/dts/exynos5250-spring.dts > index 866beb4e0597..142e0550e223 100644 > --- a/arch/arm/boot/dts/exynos5250-spring.dts > +++ b/arch/arm/boot/dts/exynos5250-spring.dts > @@ -49,6 +49,17 @@ > }; > }; > > + sound { > + compatible = "google,snow-audio-max98089"; > + samsung,model = "Spring-I2S-MAX98089"; > + samsung,i2s-controller = <&i2s0>; > + samsung,audio-codec = <&max98089>; > + clocks = <&pmu_system_controller 0>; > + clock-names = "mclk"; Related to my comment in patch 1/6, "mclk" should be defined in the codec device node. I know that you probably used as a reference Tushar's patch [0] I posted recently but I just figured out that his dependency patch [1] mentioned in [2] handled the master clock in the ASoC machine driver but the final version merged handled it in the codec drivers. I asked Kukjin to drop the patch to Snow and Peach Pit/Pi and will post a correct version as a part of a series once I've sound working. > + pinctrl-names = "default"; > + pinctrl-0 = <&mic_det_gpio>, <&hp_det_gpio>; > + }; > + The mic and headphone jack detection are still not supported in the Snow ASoC machine driver so this pinctrl are not needed but I guess it doesn't hurt to have them mux'ed too. Best regards, Javier [0]: https://lkml.org/lkml/2015/2/6/495 [1]: https://lkml.org/lkml/2014/5/20/4 [2]: https://patches.linaro.org/30406/