From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752789AbbBSR0O (ORCPT ); Thu, 19 Feb 2015 12:26:14 -0500 Received: from queue01a.mail.zen.net.uk ([212.23.3.234]:51635 "EHLO queue01a.mail.zen.net.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751934AbbBSR0N (ORCPT ); Thu, 19 Feb 2015 12:26:13 -0500 X-Greylist: delayed 1752 seconds by postgrey-1.27 at vger.kernel.org; Thu, 19 Feb 2015 12:26:13 EST Message-ID: <54E61488.2020402@cantab.net> Date: Thu, 19 Feb 2015 16:51:20 +0000 From: David Vrabel User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Bob Liu , xen-devel@lists.xen.org CC: hch@infradead.org, felipe.franciosi@citrix.com, linux-kernel@vger.kernel.org, axboe@fb.com, david.vrabel@citrix.com, avanzini.arianna@gmail.com, roger.pau@citrix.com References: <1423988345-4005-1-git-send-email-bob.liu@oracle.com> <1423988345-4005-11-git-send-email-bob.liu@oracle.com> In-Reply-To: <1423988345-4005-11-git-send-email-bob.liu@oracle.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 82.70.146.43 X-SA-Exim-Mail-From: dvrabel@cantab.net Subject: Re: [Xen-devel] [PATCH 10/10] xen/blkfront: use work queue to fast blkif interrupt return X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on pear.davidvrabel.org.uk) X-Originating-smarthost01c-IP: [82.70.146.41] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 15/02/2015 08:19, Bob Liu wrote: > Move the request complete logic out of blkif_interrupt() to a work queue, > after that we can replace 'spin_lock_irq' with 'spin_lock' so that irq won't > be disabled too long in blk_mq_queue_rq(). I think using a threaded interrupt (like scsifront) is better than work. Also, this seems orthogonal to the multiqueue support. Is it a useful bug fix on its own? David