From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752943AbbBSR4k (ORCPT ); Thu, 19 Feb 2015 12:56:40 -0500 Received: from cantor2.suse.de ([195.135.220.15]:38270 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752034AbbBSR4i (ORCPT ); Thu, 19 Feb 2015 12:56:38 -0500 Message-ID: <54E623C9.7070001@suse.de> Date: Thu, 19 Feb 2015 18:56:25 +0100 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= Organization: SUSE Linux GmbH User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Doug Anderson CC: Mark Brown , Sangbeom Kim , alsa-devel@alsa-project.org, linux-samsung-soc , Liam Girdwood , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" , Vincent Palatin , Javier Martinez Canillas , Tomasz Figa , Kukjin Kim , Jaroslav Kysela , Takashi Iwai , Olof Johansson Subject: Re: [PATCH 5/6] ASoC: samsung: Extend Snow driver to support max98089 References: <1424283959-16289-1-git-send-email-afaerber@suse.de> <1424283959-16289-6-git-send-email-afaerber@suse.de> <20150219094425.GB3198@finisterre.sirena.org.uk> In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 19.02.2015 um 18:44 schrieb Doug Anderson: > On Thu, Feb 19, 2015 at 1:44 AM, Mark Brown wrote: >> On Wed, Feb 18, 2015 at 07:25:58PM +0100, Andreas Färber wrote: >> >>> static const struct of_device_id snow_of_match[] = { >>> + { .compatible = "google,snow-audio-max98089", }, >>> { .compatible = "google,snow-audio-max98090", }, >>> { .compatible = "google,snow-audio-max98091", }, >>> { .compatible = "google,snow-audio-max98095", }, >> >> Since we completely ignore the CODEC in the property might it not be >> better to just add a plain old snow-audio compatible and bind to that, >> that way we don't need these driver updates? Just the "snow" bit should >> be enough to know it's one of this class of machines. > > I think what you're suggesting is that here we should add a new > compatible string "google,snow-audio" instead of adding > "google,snow-audio-max98089" here. Then the sound node in the spring > DTS would look like: > > compatible = "google,snow-audio-max98089", "google,snow-audio"; If we want to be specific just in case, was it an active decision not to use "google,peach-pi[t]-audio-max98..."? Again, either way works for me. Andreas -- SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Felix Imendörffer, Jane Smithard, Jennifer Guild, Dilip Upmanyu, Graham Norton; HRB 21284 (AG Nürnberg)