From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752950AbbBSSK3 (ORCPT ); Thu, 19 Feb 2015 13:10:29 -0500 Received: from smarthost01d.mail.zen.net.uk ([212.23.1.7]:60171 "EHLO smarthost01d.mail.zen.net.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751897AbbBSSK2 (ORCPT ); Thu, 19 Feb 2015 13:10:28 -0500 Message-ID: <54E6270E.6040105@cantab.net> Date: Thu, 19 Feb 2015 18:10:22 +0000 From: David Vrabel User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Juergen Gross , linux-kernel@vger.kernel.org, xen-devel@lists.xensource.com, konrad.wilk@oracle.com, david.vrabel@citrix.com, boris.ostrovsky@oracle.com References: <1424242326-26611-1-git-send-email-jgross@suse.com> <1424242326-26611-6-git-send-email-jgross@suse.com> In-Reply-To: <1424242326-26611-6-git-send-email-jgross@suse.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 82.70.146.43 X-SA-Exim-Mail-From: dvrabel@cantab.net Subject: Re: [Xen-devel] [PATCH 05/13] xen: simplify xen_set_identity_and_remap() by using global variables X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on pear.davidvrabel.org.uk) X-Originating-smarthost01d-IP: [82.70.146.41] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 18/02/2015 06:51, Juergen Gross wrote: > xen_set_identity_and_remap() is used to prepare remapping of memory > conflicting with the E820 map. It is tracking the pfn where to remap > new memory via a local variable which is passed to a subfunction > which in turn returns the new value for that variable. > > Additionally the targeted maximum pfn is passed as a parameter to > sub functions. > > Simplify that construct by using just global variables in the > source for that purpose. This will make things simpler when we need > those values later, too. I'm not convinced this actually simplifies anything. David