From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753757AbbBTDKV (ORCPT ); Thu, 19 Feb 2015 22:10:21 -0500 Received: from mail-qg0-f54.google.com ([209.85.192.54]:53717 "EHLO mail-qg0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753352AbbBTDKU (ORCPT ); Thu, 19 Feb 2015 22:10:20 -0500 Message-ID: <54E6A598.9010501@acm.org> Date: Thu, 19 Feb 2015 21:10:16 -0600 From: Corey Minyard Reply-To: minyard@acm.org User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: Joe Perches CC: openipmi-developer@lists.sourceforge.net, LKML Subject: Re: [PATCH] ipmi: Remove uses of return value of seq_printf References: <1424200256.25416.3.camel@perches.com> <54E4D26B.6020509@acm.org> <1424304173.25416.28.camel@perches.com> In-Reply-To: <1424304173.25416.28.camel@perches.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Not a big deal, thanks for following up. Send a relative patch, please. I already have this queued for upstream. -corey On 02/18/2015 06:02 PM, Joe Perches wrote: > On Wed, 2015-02-18 at 11:56 -0600, Corey Minyard wrote: >> Thanks, queued for 3.20. > Hey Corey, thanks, but I'll either have to send a new > patch or an updated patch changing these new > seq_has_overflowed() uses to 0. > > There's no functional difference, but there is a logical > one. has_overflowed(), if it returns "true" (it won't here > because the first alloc seq_fs does has sufficient space) > would not retry and simply not emit anything. > > Anyway, do you want a new patch or a relative patch? > > sorry 'bout that, Joe >