From: Stanimir Varbanov <svarbanov@mm-sol.com>
To: "Matwey V. Kornilov" <matwey@sai.msu.ru>
Cc: mohit.kumar@st.com, viresh.kumar@linaro.org,
linux-pci@vger.kernel.org, gregkh@linuxfoundation.org,
bhelgaas@google.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] pci: spear: Drop __initdata from spear13xx_pcie_driver
Date: Fri, 20 Feb 2015 12:06:36 +0200 [thread overview]
Message-ID: <54E7072C.30303@mm-sol.com> (raw)
In-Reply-To: <1424367708-17149-1-git-send-email-matwey@sai.msu.ru>
On 02/19/2015 07:41 PM, Matwey V. Kornilov wrote:
> spear13xx_pcie_driver.driver is allocated in text.init section
> and then the pointer to it is passed futher. This patch is to avoid
> crashes like the following, when freed memory is used.
>
> Also, __init has been dropped from the probe() function referred from the struct
> and all called functions.
>
<snip>
>
> Signed-off-by: Matwey V. Kornilov <matwey@sai.msu.ru>
> ---
> Changes from v2:
> - Drop __init from all probing functions to allow deferred probing.
> Changes from v1:
> - Use platform_driver_probe instead of platform_driver_register to make linker happy.
>
> drivers/pci/host/pcie-designware.c | 2 +-
> drivers/pci/host/pcie-spear13xx.c | 6 +++---
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/pci/host/pcie-designware.c b/drivers/pci/host/pcie-designware.c
> index df781cd..5b8a056 100644
> --- a/drivers/pci/host/pcie-designware.c
> +++ b/drivers/pci/host/pcie-designware.c
> @@ -339,7 +339,7 @@ static const struct irq_domain_ops msi_domain_ops = {
> .map = dw_pcie_msi_map,
> };
>
> -int __init dw_pcie_host_init(struct pcie_port *pp)
> +int dw_pcie_host_init(struct pcie_port *pp)
> {
we need to fix up the other pci drivers which use dw_pcie_host_init(), too.
pci-exynos, pci-imx6, pci-keystone and pci-layerscape.
Could you prepare a patch with above drivers included?
<snip>
--
regards,
Stan
next prev parent reply other threads:[~2015-02-20 10:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-19 17:41 [PATCH v3] pci: spear: Drop __initdata from spear13xx_pcie_driver Matwey V. Kornilov
2015-02-20 3:35 ` Viresh Kumar
2015-02-20 10:06 ` Stanimir Varbanov [this message]
2015-02-20 10:13 ` Matwey V. Kornilov
2015-02-20 14:38 ` Stanimir Varbanov
2015-03-06 14:42 ` Stanimir Varbanov
2015-03-06 16:39 ` Matwey V. Kornilov
2015-03-06 18:16 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54E7072C.30303@mm-sol.com \
--to=svarbanov@mm-sol.com \
--cc=bhelgaas@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=matwey@sai.msu.ru \
--cc=mohit.kumar@st.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).