From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754379AbbBTMMZ (ORCPT ); Fri, 20 Feb 2015 07:12:25 -0500 Received: from mailout2.w1.samsung.com ([210.118.77.12]:53156 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754045AbbBTMMW (ORCPT ); Fri, 20 Feb 2015 07:12:22 -0500 MIME-version: 1.0 Content-type: text/plain; charset=utf-8 X-AuditID: cbfec7f4-b7f126d000001e9a-ef-54e724132527 Content-transfer-encoding: 8BIT Message-id: <54E7249F.2020900@samsung.com> Date: Fri, 20 Feb 2015 13:12:15 +0100 From: Sylwester Nawrocki User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.1.2 To: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= Cc: Javier Martinez Canillas , Doug Anderson , alsa-devel@alsa-project.org, linux-samsung-soc , Sangbeom Kim , Liam Girdwood , Mark Brown , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" , Vincent Palatin , Tomasz Figa , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala Subject: Re: [PATCH 1/6] ASoC: max98088: Document DT bindings References: <1424283959-16289-1-git-send-email-afaerber@suse.de> <1424283959-16289-2-git-send-email-afaerber@suse.de> <54E5EB36.9020007@collabora.co.uk> <54E5EF73.2090302@suse.de> <54E62E1C.4030105@suse.de> <54E6314E.5060509@suse.de> <54E64C09.5000505@collabora.co.uk> <54E681A8.6040702@suse.de> In-reply-to: <54E681A8.6040702@suse.de> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupnkeLIzCtJLcpLzFFi42I5/e/4ZV1hlechBo82MVk0byq2uHLxEJPF 1IdP2CzmHznHanF22UE2i/43C1ktzr1ayWhx9HeBxbcrHUwWmx5fY7W4vGsOm8WM8/uYLJZe v8hkMWH6WhaL1r1H2C0urvjCZLFq1x9Gi23f7rA4CHls+NzE5rFm3hpGj9kNF1k8Lvf1Mnn8 fX6dxWPnrLvsHiuXf2Hz2LSqk81j85J6j74tqxg9Np+u9vi8SS6AJ4rLJiU1J7MstUjfLoEr 487FVraCmRwV9681MzUwXmDrYuTkkBAwkVh3/jsrhC0mceHeerC4kMBSRokbL8NBbF4BQYkf k++xdDFycDALyEscuZQNYapLTJmS28XIBVT9iVHi3pcWJohyLYnO5pdgY1gEVCUmXPvOAmKz CRhK9B7tYwSxRQUiJE7e3cMOYosImEt0b3zICDKIWaCTTWLnwvvMIAlhAVuJ468+skLc841J 4sZ/K5DFnECLVz2ynsAoMAvJdbMQrpuFcN0CRuZVjKKppckFxUnpuYZ6xYm5xaV56XrJ+bmb GCGR+GUH4+JjVocYBTgYlXh4f+x5FiLEmlhWXJl7iFGCg1lJhNdT4XmIEG9KYmVValF+fFFp TmrxIUYmDk6pBsbOd2mHk8o/ZzqEb1f/o/o6xP1WRr29cfrEGGEVwe0HhULsc6TaX0cf2X7J bvku55KyV5UTCid5mznfdzTP2ffe8HjqobaEbI2gxFmb/3zULmdI+c0kZPjwe+x/S6fknsVO 2y9w7rZsTZb4wXM447La5W0eOVoVubtnnp/MKG+8cbNv5EOfdUosxRmJhlrMRcWJAIM9mbyi AgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 20/02/15 01:36, Andreas Färber wrote: >>> >> So it seems the mclk is not always set up properly by the kernel, >>> >> relying on firmware. Who's in charge of setting that clock up? >> > >> > Right, it seems audio is only working due the firmware doing some previous >> > setup. Probably it works on every boot if you have "sound init" as a part of >> > the u-boot boot commands? > > Indeed it does, 24 MHz without the reparenting patch, and sound working. You can have parent of the CLKOUT clock set by the clk core if it is specified in device tree in the PMU (the clkout clock supplier) device node. Similarly as we did for the Odroix U3: https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/arch/arm/boot/dts/exynos4412-odroid-common.dtsi#n39 Relying on the clk_set_rate() to set the parent clock is not optimal IMO. Presumably you need to set select stable parent clock for clkout like XXTI. But I'm not very familiar with exyno5250 and that might be something different. -- Regards, Sylwester