From: Michal Marek <mmarek@suse.cz>
To: David Howells <dhowells@redhat.com>
Cc: keyrings@linux-nfs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] X.509: Fix certificate gathering again
Date: Fri, 20 Feb 2015 14:52:14 +0100 [thread overview]
Message-ID: <54E73C0E.1090905@suse.cz> (raw)
In-Reply-To: <11027.1424348805@warthog.procyon.org.uk>
On 2015-02-19 13:26, David Howells wrote:
> Michal Marek <mmarek@suse.cz> wrote:
>
>> +X509_CERTIFICATES-y := $(wildcard *.x509)
>> +ifneq ($(objtree),$(srctree))
>> +X509_CERTIFICATES-y += $(wildcard $(srctree)/*.x509)
>> +endif
>> +X509_CERTIFICATES-$(CONFIG_MODULE_SIG) += signing_key.x509
>> +X509_CERTIFICATES := $(sort $(X509_CERTIFICATES-y))
>
> What will happen if there's a "signing_key.x509" in the source tree when O= is
> used?
It will fail. So the patch needs more work, thanks for the review.
Michal
next prev parent reply other threads:[~2015-02-20 13:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-08 13:03 [PATCH] X.509: Fix certificate gathering again Michal Marek
2015-02-19 12:26 ` David Howells
2015-02-20 13:52 ` Michal Marek [this message]
2015-02-20 22:10 ` Michal Marek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54E73C0E.1090905@suse.cz \
--to=mmarek@suse.cz \
--cc=dhowells@redhat.com \
--cc=keyrings@linux-nfs.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox