From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754550AbbBTNwR (ORCPT ); Fri, 20 Feb 2015 08:52:17 -0500 Received: from cantor2.suse.de ([195.135.220.15]:36513 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753893AbbBTNwQ (ORCPT ); Fri, 20 Feb 2015 08:52:16 -0500 Message-ID: <54E73C0E.1090905@suse.cz> Date: Fri, 20 Feb 2015 14:52:14 +0100 From: Michal Marek User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: David Howells CC: keyrings@linux-nfs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] X.509: Fix certificate gathering again References: <1412773409-29102-1-git-send-email-mmarek@suse.cz> <11027.1424348805@warthog.procyon.org.uk> In-Reply-To: <11027.1424348805@warthog.procyon.org.uk> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2015-02-19 13:26, David Howells wrote: > Michal Marek wrote: > >> +X509_CERTIFICATES-y := $(wildcard *.x509) >> +ifneq ($(objtree),$(srctree)) >> +X509_CERTIFICATES-y += $(wildcard $(srctree)/*.x509) >> +endif >> +X509_CERTIFICATES-$(CONFIG_MODULE_SIG) += signing_key.x509 >> +X509_CERTIFICATES := $(sort $(X509_CERTIFICATES-y)) > > What will happen if there's a "signing_key.x509" in the source tree when O= is > used? It will fail. So the patch needs more work, thanks for the review. Michal