[PATCH] perf: Only include tsc file for x86

[PATCH] perf: Only include tsc file for x86

[David Ahern]

perf_time_to_tsc and tsc_to_perf_time are only used for x86. Make
inclusion of tsc.c dependent on x86 as well.

Signed-off-by: David Ahern <david.ahern@oracle.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Jiri Olsa <jolsa@kernel.org>
---
 tools/perf/util/Build | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/util/Build b/tools/perf/util/Build
index 32f9327b1a97..4c7095785ba0 100644
--- a/tools/perf/util/Build
+++ b/tools/perf/util/Build
@@ -71,7 +71,7 @@ libperf-y += stat.o
 libperf-y += record.o
 libperf-y += srcline.o
 libperf-y += data.o
-libperf-y += tsc.o
+libperf-$(CONFIG_X86) += tsc.o
 libperf-y += cloexec.o
 libperf-y += thread-stack.o
 
-- 
1.9.3

Re: [PATCH] perf: Only include tsc file for x86

[Jiri Olsa]

On Thu, Feb 19, 2015 at 01:22:33PM -0500, David Ahern wrote:
> perf_time_to_tsc and tsc_to_perf_time are only used for x86. Make
> inclusion of tsc.c dependent on x86 as well.

hum, should we move it to arch/x86/util/tsc.c and remove util/tsc.c?

looks like it's used only by test tsc code, which is enabled
for x86 only anyway..

jirka

> 
> Signed-off-by: David Ahern <david.ahern@oracle.com>
> Cc: Adrian Hunter <adrian.hunter@intel.com>
> Cc: Jiri Olsa <jolsa@kernel.org>
> ---
>  tools/perf/util/Build | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/perf/util/Build b/tools/perf/util/Build
> index 32f9327b1a97..4c7095785ba0 100644
> --- a/tools/perf/util/Build
> +++ b/tools/perf/util/Build
> @@ -71,7 +71,7 @@ libperf-y += stat.o
>  libperf-y += record.o
>  libperf-y += srcline.o
>  libperf-y += data.o
> -libperf-y += tsc.o
> +libperf-$(CONFIG_X86) += tsc.o
>  libperf-y += cloexec.o
>  libperf-y += thread-stack.o
>  
> -- 
> 1.9.3
> 

Re: [PATCH] perf: Only include tsc file for x86

[Adrian Hunter]

On 19/02/15 21:42, Jiri Olsa wrote:
> On Thu, Feb 19, 2015 at 01:22:33PM -0500, David Ahern wrote:
>> perf_time_to_tsc and tsc_to_perf_time are only used for x86. Make
>> inclusion of tsc.c dependent on x86 as well.
> 
> hum, should we move it to arch/x86/util/tsc.c and remove util/tsc.c?

It is not arch-specific because you can read a perf.data file
from one architecture on another architecture.

The TSC stuff was planned for Intel PT although it might now
be done differently.

Probably you should have CONFIG_X86_TSC and then select that
with CONFIG_X86. Later it can be selected with CONFIG_INTEL_PT
as well.

> 
> looks like it's used only by test tsc code, which is enabled
> for x86 only anyway..
> 
> jirka
> 
>>
>> Signed-off-by: David Ahern <david.ahern@oracle.com>
>> Cc: Adrian Hunter <adrian.hunter@intel.com>
>> Cc: Jiri Olsa <jolsa@kernel.org>
>> ---
>>  tools/perf/util/Build | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/tools/perf/util/Build b/tools/perf/util/Build
>> index 32f9327b1a97..4c7095785ba0 100644
>> --- a/tools/perf/util/Build
>> +++ b/tools/perf/util/Build
>> @@ -71,7 +71,7 @@ libperf-y += stat.o
>>  libperf-y += record.o
>>  libperf-y += srcline.o
>>  libperf-y += data.o
>> -libperf-y += tsc.o
>> +libperf-$(CONFIG_X86) += tsc.o
>>  libperf-y += cloexec.o
>>  libperf-y += thread-stack.o
>>  
>> -- 
>> 1.9.3
>>
> 
> 

Re: [PATCH] perf: Only include tsc file for x86

[David Ahern]

On 2/20/15 1:36 AM, Adrian Hunter wrote:
> On 19/02/15 21:42, Jiri Olsa wrote:
>> On Thu, Feb 19, 2015 at 01:22:33PM -0500, David Ahern wrote:
>>> perf_time_to_tsc and tsc_to_perf_time are only used for x86. Make
>>> inclusion of tsc.c dependent on x86 as well.
>>
>> hum, should we move it to arch/x86/util/tsc.c and remove util/tsc.c?
>
> It is not arch-specific because you can read a perf.data file
> from one architecture on another architecture.
>
> The TSC stuff was planned for Intel PT although it might now
> be done differently.
>
> Probably you should have CONFIG_X86_TSC and then select that
> with CONFIG_X86. Later it can be selected with CONFIG_INTEL_PT
> as well.

For now let's leave it as CONFIG_X86. Right now only X86 code needs the 
functions it provides and there is no need taking any other steps until 
something is going to use it.

ie., patch is good as is. Agreed?

David

>
>>
>> looks like it's used only by test tsc code, which is enabled
>> for x86 only anyway..
>>
>> jirka
>>
>>>
>>> Signed-off-by: David Ahern <david.ahern@oracle.com>
>>> Cc: Adrian Hunter <adrian.hunter@intel.com>
>>> Cc: Jiri Olsa <jolsa@kernel.org>
>>> ---
>>>   tools/perf/util/Build | 2 +-
>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/tools/perf/util/Build b/tools/perf/util/Build
>>> index 32f9327b1a97..4c7095785ba0 100644
>>> --- a/tools/perf/util/Build
>>> +++ b/tools/perf/util/Build
>>> @@ -71,7 +71,7 @@ libperf-y += stat.o
>>>   libperf-y += record.o
>>>   libperf-y += srcline.o
>>>   libperf-y += data.o
>>> -libperf-y += tsc.o
>>> +libperf-$(CONFIG_X86) += tsc.o
>>>   libperf-y += cloexec.o
>>>   libperf-y += thread-stack.o
>>>
>>> --
>>> 1.9.3
>>>
>>
>>
>

Re: [PATCH] perf: Only include tsc file for x86

[Jiri Olsa]

On Fri, Feb 20, 2015 at 09:40:57AM -0700, David Ahern wrote:
> On 2/20/15 1:36 AM, Adrian Hunter wrote:
> >On 19/02/15 21:42, Jiri Olsa wrote:
> >>On Thu, Feb 19, 2015 at 01:22:33PM -0500, David Ahern wrote:
> >>>perf_time_to_tsc and tsc_to_perf_time are only used for x86. Make
> >>>inclusion of tsc.c dependent on x86 as well.
> >>
> >>hum, should we move it to arch/x86/util/tsc.c and remove util/tsc.c?
> >
> >It is not arch-specific because you can read a perf.data file
> >from one architecture on another architecture.
> >
> >The TSC stuff was planned for Intel PT although it might now
> >be done differently.
> >
> >Probably you should have CONFIG_X86_TSC and then select that
> >with CONFIG_X86. Later it can be selected with CONFIG_INTEL_PT
> >as well.
> 
> For now let's leave it as CONFIG_X86. Right now only X86 code needs the
> functions it provides and there is no need taking any other steps until
> something is going to use it.
> 
> ie., patch is good as is. Agreed?

ook, jirka

[tip:perf/core] perf tools: Only include tsc file for x86

[tip-bot for David Ahern]

Commit-ID:  ecefde629fadd3fcca2ea4c6a799d6e6aab8781f
Gitweb:     http://git.kernel.org/tip/ecefde629fadd3fcca2ea4c6a799d6e6aab8781f
Author:     David Ahern <david.ahern@oracle.com>
AuthorDate: Thu, 19 Feb 2015 13:22:33 -0500
Committer:  Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Mon, 2 Mar 2015 11:50:08 -0300

perf tools: Only include tsc file for x86

The perf_time_to_tsc and tsc_to_perf_time functions are only used for x86.

Make inclusion of tsc.c dependent on x86 as well.

Signed-off-by: David Ahern <david.ahern@oracle.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: David Ahern <david.ahern@oracle.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Link: http://lkml.kernel.org/r/1424370153-128274-1-git-send-email-david.ahern@oracle.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/util/Build | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/util/Build b/tools/perf/util/Build
index a2c8047..972a6e0 100644
--- a/tools/perf/util/Build
+++ b/tools/perf/util/Build
@@ -71,7 +71,7 @@ libperf-y += stat.o
 libperf-y += record.o
 libperf-y += srcline.o
 libperf-y += data.o
-libperf-y += tsc.o
+libperf-$(CONFIG_X86) += tsc.o
 libperf-y += cloexec.o
 libperf-y += thread-stack.o