From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755040AbbBTT1p (ORCPT <rfc822;w@1wt.eu>);
	Fri, 20 Feb 2015 14:27:45 -0500
Received: from mail-pd0-f177.google.com ([209.85.192.177]:33890 "EHLO
	mail-pd0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753700AbbBTT1n (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 20 Feb 2015 14:27:43 -0500
From: Andy Lutomirski <luto@amacapital.net>
X-Google-Original-From: Andy Lutomirski <luto@mit.edu>
Message-ID: <54E78AAB.2020604@mit.edu>
Date: Fri, 20 Feb 2015 11:27:39 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0
MIME-Version: 1.0
To: Bastien Nocera <hadess@hadess.net>,
        Henrique de Moraes Holschuh <ibm-acpi@hmh.eng.br>,
        Darren Hart <dvhart@infradead.org>,
        ibm-acpi-devel@lists.sourceforge.net,
        platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-input@vger.kernel.org, Jiri Kosina <jkosina@suse.cz>
Subject: Re: [PATCH 6/7] thinkpad_acpi: More Carbon X1 2014 keys
References: <1424443477.22910.18.camel@hadess.net>
In-Reply-To: <1424443477.22910.18.camel@hadess.net>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 02/20/2015 06:44 AM, Bastien Nocera wrote:
> +		KEY_MICCANCEL_MODE,  /* Microphone cancellation */

What's this?  We already have KEY_MICMUTE.  Is this different?  If so, 
can you improve the comment a bit?

The answer may be obvious to anyone who has an awful X1 carbon gen 2 
keyboard, but these KEY_XYZ defines should IMO be clear enough that even 
people without the hardware can figure out what's going on.

--Andy