From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752145AbbBVVKV (ORCPT ); Sun, 22 Feb 2015 16:10:21 -0500 Received: from www62.your-server.de ([213.133.104.62]:43820 "EHLO www62.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752027AbbBVVKT (ORCPT ); Sun, 22 Feb 2015 16:10:19 -0500 Message-ID: <54EA45B1.6080701@iogearbox.net> Date: Sun, 22 Feb 2015 22:10:09 +0100 From: Daniel Borkmann User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Sasha Levin , herbert@gondor.apana.org.au, tgraf@suug.ch CC: netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] rhashtable: initialize all rhashtable walker members References: <1424552111-12077-1-git-send-email-sasha.levin@oracle.com> In-Reply-To: <1424552111-12077-1-git-send-email-sasha.levin@oracle.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Authenticated-Sender: daniel@iogearbox.net Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/21/2015 09:55 PM, Sasha Levin wrote: > Commit "rhashtable: Introduce rhashtable_walk_*" forgot to initialize the > members of struct rhashtable_walker after allocating it, which caused > an undefined value for 'resize' which is used later on. > > Signed-off-by: Sasha Levin > --- > lib/rhashtable.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/lib/rhashtable.c b/lib/rhashtable.c > index 9cc4c4a..030484c 100644 > --- a/lib/rhashtable.c > +++ b/lib/rhashtable.c > @@ -894,6 +894,9 @@ int rhashtable_walk_init(struct rhashtable *ht, struct rhashtable_iter *iter) > if (!iter->walker) > return -ENOMEM; > > + INIT_LIST_HEAD(&iter->walker->list); > + iter->walker->resize = false; > + The change seems fine to me, although the INIT_LIST_HEAD() unnecessary due to the below list_add()? Anyway, setting resize to false is definitely correct. In practice this shouldn't cause much issue though as rhashtable_walk_start() would only reset iterator meta data and set resize to false, but lets fix it. > mutex_lock(&ht->mutex); > list_add(&iter->walker->list, &ht->walkers); > mutex_unlock(&ht->mutex); Thanks, Daniel