From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752980AbbBWQgI (ORCPT ); Mon, 23 Feb 2015 11:36:08 -0500 Received: from service87.mimecast.com ([91.220.42.44]:34681 "EHLO service87.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752149AbbBWQgH convert rfc822-to-8bit (ORCPT ); Mon, 23 Feb 2015 11:36:07 -0500 Message-ID: <54EB56FC.9060205@arm.com> Date: Mon, 23 Feb 2015 16:36:12 +0000 From: Sudeep Holla User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Borislav Petkov CC: Thomas Gleixner , Sudeep Holla , LKML , "x86@kernel.org" , "H. Peter Anvin" , Ingo Molnar Subject: Re: [PATCH RFT] x86: move cacheinfo sysfs to generic cacheinfo infrastructure References: <1420703406-10637-1-git-send-email-sudeep.holla@arm.com> <20150123181538.GG2041@pd.tnic> In-Reply-To: <20150123181538.GG2041@pd.tnic> X-OriginalArrivalTime: 23 Feb 2015 16:36:01.0619 (UTC) FILETIME=[CF51A230:01D04F86] X-MC-Unique: 115022316360405401 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Boris, On 23/01/15 18:15, Borislav Petkov wrote: > On Fri, Jan 23, 2015 at 02:55:03PM +0100, Thomas Gleixner wrote: >> Cc: Boris >> >> On Thu, 8 Jan 2015, Sudeep Holla wrote: >> >>> This patch removes the redundant sysfs cacheinfo code by reusing >>> the newly introduced generic cacheinfo infrastructure through the >>> commit 246246cbde5e ("drivers: base: support cpu cache information >>> interface to userspace via sysfs") >>> >>> The private pointer provided by the cacheinfo is used to implement >>> the AMD L3 cache specific attributes. >>> >>> Signed-off-by: Sudeep Holla >>> Cc: Thomas Gleixner >>> Cc: Ingo Molnar >>> Cc: "H. Peter Anvin" >>> Cc: x86@kernel.org > > ... > [ 2.878173] ACPI: processor limited to max C-state 1 > [ 2.884048] Serial: 8250/16550 driver, 4 ports, IRQ sharing enabled > [ 2.911085] 00:01: ttyS0 at I/O 0x3f8 (irq = 4, base_baud = 115200) is a 16550A > [ 2.920699] Linux agpgart interface v0.103 > [ 2.924908] [drm] Initialized drm 1.1.0 20060810 > [ 2.929719] ------------[ cut here ]------------ > [ 2.934419] WARNING: CPU: 0 PID: 1 at kernel/locking/lockdep.c:2744 lockdep_trace_alloc+0xd4/0xe0() > [ 2.943591] DEBUG_LOCKS_WARN_ON(irqs_disabled_flags(flags)) Sorry for late response, was on vacation. I have fixed this issue now and will post the new version soon. Thanks a lot for trying it out. Regards, Sudeep