From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752919AbbBWQtm (ORCPT ); Mon, 23 Feb 2015 11:49:42 -0500 Received: from mail-ie0-f177.google.com ([209.85.223.177]:41331 "EHLO mail-ie0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752339AbbBWQtl (ORCPT ); Mon, 23 Feb 2015 11:49:41 -0500 Message-ID: <54EB5A1F.70306@gmail.com> Date: Mon, 23 Feb 2015 09:49:35 -0700 From: David Ahern User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Peter Zijlstra CC: linux-kernel@vger.kernel.org Subject: Re: [PATCH] perf/x86: Remove redundant calls to perf_pmu_{dis|en}able References: <1424281543-67335-1-git-send-email-dsahern@gmail.com> In-Reply-To: <1424281543-67335-1-git-send-email-dsahern@gmail.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Peter: On 2/18/15 10:45 AM, David Ahern wrote: > perf_pmu_disable is called before pmu->add and perf_pmu_enable is called > afterwards. No need to call these inside of x86_pmu_add as well. Does this make sense or did I miss something about the pmu_enable/disable functions? David > > Signed-off-by: David Ahern > Cc: Peter Zijlstra > --- > arch/x86/kernel/cpu/perf_event.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/arch/x86/kernel/cpu/perf_event.c b/arch/x86/kernel/cpu/perf_event.c > index b71a7f86d68a..2d1675816bef 100644 > --- a/arch/x86/kernel/cpu/perf_event.c > +++ b/arch/x86/kernel/cpu/perf_event.c > @@ -1033,7 +1033,6 @@ static int x86_pmu_add(struct perf_event *event, int flags) > > hwc = &event->hw; > > - perf_pmu_disable(event->pmu); > n0 = cpuc->n_events; > ret = n = collect_events(cpuc, event, false); > if (ret < 0) > @@ -1071,7 +1070,6 @@ static int x86_pmu_add(struct perf_event *event, int flags) > > ret = 0; > out: > - perf_pmu_enable(event->pmu); > return ret; > } > >