From: Chanwoo Choi <cw00.choi@samsung.com>
To: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Cc: rtc-linux@googlegroups.com, a.zummo@towertech.it,
akpm@linux-foundation.org, inki.dae@samsung.com,
linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org
Subject: Re: [rtc-linux] [PATCH v3] rtc: s5m: Add the support for S2MPS13 RTC
Date: Tue, 24 Feb 2015 17:43:49 +0900 [thread overview]
Message-ID: <54EC39C5.7010209@samsung.com> (raw)
In-Reply-To: <CAJKOXPdb9=B-s=EEdB8-pDoDNw8KyZwuD68_NgcAdVpBc-v0hg@mail.gmail.com>
On 02/24/2015 05:21 PM, Krzysztof Kozlowski wrote:
> 2015-02-24 7:09 GMT+01:00 Chanwoo Choi <cw00.choi@samsung.com>:
>> This patch adds only the compatible string for S2MPS13 clock which is identical
>> with S2MPS14 clock driver.
>
> If everything is identical then maybe use the same ID?
> { "s5m-rtc", S5M8767X },
> + { "s2mps13-rtc", S2MPS14X },
> { "s2mps14-rtc", S2MPS14X },
>
> Or in mfd/sec-core:
> static const struct mfd_cell s2mps13_devs[] = {
> - { .name = "s2mps13-rtc", },
> + { .name = "s2mps14-rtc", },
>
> The duplication of all S2MPS14 labels seems not necessary in such case.
OK, I agree, I'll send patch according to your comment.
Thanks,
Chanwoo Choi
prev parent reply other threads:[~2015-02-24 8:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-24 6:09 [PATCH v3] rtc: s5m: Add the support for S2MPS13 RTC Chanwoo Choi
2015-02-24 8:21 ` [rtc-linux] " Krzysztof Kozlowski
2015-02-24 8:43 ` Chanwoo Choi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54EC39C5.7010209@samsung.com \
--to=cw00.choi@samsung.com \
--cc=a.zummo@towertech.it \
--cc=akpm@linux-foundation.org \
--cc=inki.dae@samsung.com \
--cc=k.kozlowski@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=rtc-linux@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox