From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752392AbbBXInx (ORCPT ); Tue, 24 Feb 2015 03:43:53 -0500 Received: from mailout3.samsung.com ([203.254.224.33]:51661 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751147AbbBXInw (ORCPT ); Tue, 24 Feb 2015 03:43:52 -0500 X-AuditID: cbfee68d-f79296d000004278-66-54ec39c5425e Message-id: <54EC39C5.7010209@samsung.com> Date: Tue, 24 Feb 2015 17:43:49 +0900 From: Chanwoo Choi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130106 Thunderbird/17.0.2 MIME-version: 1.0 To: Krzysztof Kozlowski Cc: rtc-linux@googlegroups.com, a.zummo@towertech.it, akpm@linux-foundation.org, inki.dae@samsung.com, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org Subject: Re: [rtc-linux] [PATCH v3] rtc: s5m: Add the support for S2MPS13 RTC References: <1424758197-20057-1-git-send-email-cw00.choi@samsung.com> In-reply-to: Content-type: text/plain; charset=UTF-8 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrCIsWRmVeSWpSXmKPExsWyRsSkWPeo5ZsQg8YjVhZLLl5lt5izfg2b xaT7E1gsXr8wtLi8aw6bxYzz+5gs9nd2MDqwe+yZeJLN48SM3ywefVtWMXpMn/eTyePzJrkA 1igum5TUnMyy1CJ9uwSujKXtN9gKfrBWHDv6mrmBcQ1LFyMnh4SAicS9+4vYIWwxiQv31rN1 MXJxCAksZZRofHgErujOsW/MEInpjBJHfrxih3BeM0r83ngCrIpXQEti2+z5rCA2i4CqxMYP fWwgNhtQfP+LG2C2qECYxMrpV6DqBSV+TL4HZosIGEoc3L2dCWQos8AqRokDK18xgySEBXwl VizaxwixrYdRYuq+F0AbODg4BYIljv0UAKlhFlCXmDRvETOELS+xec1bsFMlBE6xSzx5sp8Z 4iIBiW+TD7GA9EoIyEpsOsAM8ZqkxMEVN1gmMIrNQnLTLCRjZyEZu4CReRWjaGpBckFxUnqR oV5xYm5xaV66XnJ+7iZGYOSd/vesdwfj7QPWhxgFOBiVeHgThN+ECLEmlhVX5h5iNAW6YiKz lGhyPjC+80riDY3NjCxMTUyNjcwtzZTEeRWlfgYLCaQnlqRmp6YWpBbFF5XmpBYfYmTi4JRq YNxu2rI069ZS5nd2X2+uPrBpYe3iL885Qw5c05T7o10uPuPqvHIb0evZ67qMtupoOfp/CXjB GGZls1QsZB1vo0PUi3dm6UL5i8UvTbt+cAlLsXf8JFsPY5u5r3ifc8h/udux2nJ27OqDzgyX Fn5gn1gdtWLSBfaON9susWz+sW6NDZOH/v64ue1KLMUZiYZazEXFiQCCzt4RtwIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrHIsWRmVeSWpSXmKPExsVy+t9jQd2jlm9CDB4tN7JYcvEqu8Wc9WvY LCbdn8Bi8fqFocXlXXPYLGac38dksb+zg9GB3WPPxJNsHidm/Gbx6NuyitFj+ryfTB6fN8kF sEY1MNpkpCampBYppOYl56dk5qXbKnkHxzvHm5oZGOoaWlqYKynkJeam2iq5+AToumXmAJ2h pFCWmFMKFApILC5W0rfDNCE0xE3XAqYxQtc3JAiux8gADSSsYcxY2n6DreAHa8Wxo6+ZGxjX sHQxcnJICJhI3Dn2jRnCFpO4cG89WxcjF4eQwHRGiSM/XrFDOK8ZJX5vPAHWwSugJbFt9nxW EJtFQFVi44c+NhCbDSi+/8UNMFtUIExi5fQrUPWCEj8m3wOzRQQMJQ7u3s4EMpRZYBWjxIGV r8BWCwv4SqxYtI8RYlsPo8TUfS+ANnBwcAoESxz7KQBSwyygLjFp3iJmCFteYvOat8wTGAVm IdkxC0nZLCRlCxiZVzGKphYkFxQnpeca6RUn5haX5qXrJefnbmIEx/Uz6R2MqxosDjEKcDAq 8fAmCr8JEWJNLCuuzD3EKMHBrCTCm/b0dYgQb0piZVVqUX58UWlOavEhRlNgEExklhJNzgem nLySeENjEzMjSyNzQwsjY3MlcV4l+7YQIYH0xJLU7NTUgtQimD4mDk4pYKLw3fNaur9f8vEs JYNz68wF+qfx9gpJHtY//UxqcvFrJp/QF4Uiqz6v5HP783r695j9DpvcdVoX7JiRufUXp9O1 6lrdD2GN3wQe7c58+v6L+Vflyzs2m50KK0+tZ4yecW7ftgmZC6JZ53QJLpdnbeXwKcl28goO kRI+3FJ7Ydnyo+HPRasSg5RYijMSDbWYi4oTAXRdP/UBAwAA DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/24/2015 05:21 PM, Krzysztof Kozlowski wrote: > 2015-02-24 7:09 GMT+01:00 Chanwoo Choi : >> This patch adds only the compatible string for S2MPS13 clock which is identical >> with S2MPS14 clock driver. > > If everything is identical then maybe use the same ID? > { "s5m-rtc", S5M8767X }, > + { "s2mps13-rtc", S2MPS14X }, > { "s2mps14-rtc", S2MPS14X }, > > Or in mfd/sec-core: > static const struct mfd_cell s2mps13_devs[] = { > - { .name = "s2mps13-rtc", }, > + { .name = "s2mps14-rtc", }, > > The duplication of all S2MPS14 labels seems not necessary in such case. OK, I agree, I'll send patch according to your comment. Thanks, Chanwoo Choi