From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752716AbbBXIqg (ORCPT ); Tue, 24 Feb 2015 03:46:36 -0500 Received: from mailout3.samsung.com ([203.254.224.33]:52551 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751444AbbBXIqe (ORCPT ); Tue, 24 Feb 2015 03:46:34 -0500 X-AuditID: cbfee690-f79ab6d0000046f7-ca-54ec3a69769c Message-id: <54EC3A68.3030207@samsung.com> Date: Tue, 24 Feb 2015 17:46:32 +0900 From: Chanwoo Choi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130106 Thunderbird/17.0.2 MIME-version: 1.0 To: Krzysztof Kozlowski Cc: Kukjin Kim , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Kyungmin Park , Marek Szyprowski , stable@vger.kernel.org Subject: Re: [RESEND PATCH] ARM: EXYNOS: Fix failed second suspend on Exynos4 References: <1424256325-16659-1-git-send-email-k.kozlowski@samsung.com> In-reply-to: <1424256325-16659-1-git-send-email-k.kozlowski@samsung.com> Content-type: text/plain; charset=ISO-8859-1 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrIIsWRmVeSWpSXmKPExsWyRsSkWDfT6k2IweoLXBavXxha9D9+zWxx tukNu8Wmx9dYLS7vmsNmMeP8PiaLtUfuslss2PiI0YHDY9OqTjaPzUvqPfq2rGL0+LxJLoAl issmJTUnsyy1SN8ugSuja+EmxoI3PBWP30xiaWA8wtXFyMkhIWAice/yLHYIW0ziwr31bF2M XBxCAksZJRo2HAVyOMCKft/ygIgvYpRYv+cIE4TzmlFi97J1rCDdvAJaEhO3rGQEsVkEVCX2 THrIAmKzAcX3v7jBBmKLCoRJrJx+hQWiXlDix+R7YLaIgKHEwd3bwYYyC/xjlPgydx/YIGEB X4knt5pZQK4QEnCXeHcnDSTMKeAhserfabCZzAI6Evtbp0HZ8hKb17xlBpkjIXCOXeLHuQ1Q BwlIfJt8iAXiG1mJTQeYIT6WlDi44gbLBEaxWUhOmoVk7CwkYxcwMq9iFE0tSC4oTkovMtEr TswtLs1L10vOz93ECIy50/+eTdjBeO+A9SFGAQ5GJR7eBOE3IUKsiWXFlbmHGE2BrpjILCWa nA+M7LySeENjMyMLUxNTYyNzSzMlcd7XUj+DhQTSE0tSs1NTC1KL4otKc1KLDzEycXBKNTBm XrjJK39A5+W9k7tti0SOxfxoTs/7Ey1z/GJnpPZyd/kZ4kFm66P/JV3P9+53lXE9sfj01uQ9 K7bqXT5bxDW9+/lH3y1TfG2f+8oyRFwO33H2sVWsZ8IE7XnrV5q/fbpvtY19hYbBizBpQ92d ce+XpT61E71aq9q8lEluWZ3pDDaXNlnt2TeVWIozEg21mIuKEwHqEEJTtAIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrNIsWRmVeSWpSXmKPExsVy+t9jAd1MqzchBq0zmCxevzC06H/8mtni bNMbdotNj6+xWlzeNYfNYsb5fUwWa4/cZbdYsPERowOHx6ZVnWwem5fUe/RtWcXo8XmTXABL VAOjTUZqYkpqkUJqXnJ+SmZeuq2Sd3C8c7ypmYGhrqGlhbmSQl5ibqqtkotPgK5bZg7QFUoK ZYk5pUChgMTiYiV9O0wTQkPcdC1gGiN0fUOC4HqMDNBAwhrGjK6FmxgL3vBUPH4ziaWB8QhX FyMHh4SAicTvWx5djJxAppjEhXvr2boYuTiEBBYxSqzfc4QJwnnNKLF72TpWkCpeAS2JiVtW MoLYLAKqEnsmPWQBsdmA4vtf3GADsUUFwiRWTr/CAlEvKPFj8j0wW0TAUOLg7u1gQ5kF/jFK fJm7D2yQsICvxJNbzSwgFwkJuEu8u5MGEuYU8JBY9e802ExmAR2J/a3ToGx5ic1r3jJPYBSY hWTFLCRls5CULWBkXsUomlqQXFCclJ5rqFecmFtcmpeul5yfu4kRHNHPpHYwrmywOMQowMGo xMObIPwmRIg1say4MvcQowQHs5IIb9rT1yFCvCmJlVWpRfnxRaU5qcWHGE2BITCRWUo0OR+Y bPJK4g2NTcyMLI3MDS2MjM2VxHmV7NtChATSE0tSs1NTC1KLYPqYODilGhiVUr9ulH4t3/88 /8LUDMHwq/WKpr1sbQz3rNwt/b8fn/u3RXTJh/drj3MVz7i+9G34I53e78+aj96S2dhj612l +q6mbPtc5Rvcr1xMwtbslXS/sO1E0M8/NwV3Xtot+EeMfVnvr+LwSc1/ePxzsl/z6jt++nso zD6T85Tz1x/NF5tS/hy5WGCoxFKckWioxVxUnAgAoEhUdv4CAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/18/2015 07:45 PM, Krzysztof Kozlowski wrote: > On Exynos4412 boards (Trats2, Odroid U3) after enabling L2 cache in > 56b60b8bce4a ("ARM: 8265/1: dts: exynos4: Add nodes for L2 cache > controller") the second suspend to RAM failed. First suspend worked fine > but the next one hang just after powering down of secondary CPUs (system > consumed energy as it would be running but was not responsive). > > The issue was caused by enabling delayed reset assertion for CPU0 just > after issuing power down of cores. This was introduced for Exynos4 in > 13cfa6c4f7fa ("ARM: EXYNOS: Fix CPU idle clock down after CPU off"). > > The whole behavior is not well documented but after checking with vendor > code this should be done like this (on Exynos4): > 1. Enable delayed reset assertion when system is running (for all CPUs). > 2. Disable delayed reset assertion before suspending the system. > This can be done after powering off secondary CPUs. > 3. Re-enable the delayed reset assertion when system is resumed. > > Signed-off-by: Krzysztof Kozlowski > Fixes: 13cfa6c4f7fa ("ARM: EXYNOS: Fix CPU idle clock down after CPU off") > Cc: > --- > arch/arm/mach-exynos/common.h | 2 ++ > arch/arm/mach-exynos/exynos.c | 27 +++++++++++++++++++++++++++ > arch/arm/mach-exynos/platsmp.c | 39 ++------------------------------------- > arch/arm/mach-exynos/suspend.c | 3 +++ > 4 files changed, 34 insertions(+), 37 deletions(-) Tested-by: Chanwoo Choi I tested this patch on Exynos4412-baed TRATS2 board. Thanks, Chanwoo Choi