From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753127AbbBXJoj (ORCPT ); Tue, 24 Feb 2015 04:44:39 -0500 Received: from mail.linn.co.uk ([195.59.102.251]:50311 "EHLO mail.linn.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752364AbbBXJoh (ORCPT ); Tue, 24 Feb 2015 04:44:37 -0500 Message-ID: <54EC4801.3080407@linn.co.uk> Date: Tue, 24 Feb 2015 09:44:33 +0000 From: Stathis Voukelatos User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: David Miller CC: , , Subject: Re: [PATCH v3 3/3] Linn Ethernet packet sniffer driver References: <34013795c99ef50fac3d2c72717971563148578c.1424698609.git.stathis.voukelatos@linn.co.uk> <20150223.163854.880151768241069377.davem@davemloft.net> In-Reply-To: <20150223.163854.880151768241069377.davem@davemloft.net> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.2.10.132] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 23/02/15 21:38, David Miller wrote: > From: Stathis Voukelatos > Date: Mon, 23 Feb 2015 14:26:22 +0000 > >> Driver for the Ethernet Mii packet sniffer H/W module found in >> the IMG Pistachio SoC. >> >> Signed-off-by: Stathis Voukelatos > > You really have to explain what this thing does, how it is used, > what APIs are made use of to maniulate this device, etc. > > Nobody knows what the packet sniffer module by your company is. > I tried to provide a description of the device in the cover letter. I will expand it and also include it in a suitable place in the actual source. > I also anticipate that once you describe adequately how this thing > behaves I won't like it, and I'll prefer that you integrate support > for your device using an exising facility such as AF_PACKET, > extending it if need be. > The driver actually relies on AF_PACKET for accessing the device. I will add some documentation to make the usage and API clearer. > I am very far away from applying this series at this point, it needs > a lot more work and explanations. > Thank you, Stathis