public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
To: Eugene Shatokhin <eugene.shatokhin@rosalab.ru>
Cc: linux-kernel@vger.kernel.org
Subject: Re: Re: Kprobes: pre-handler with interrupts enabled - is it possible?
Date: Tue, 24 Feb 2015 19:24:32 +0900	[thread overview]
Message-ID: <54EC5160.7090400@hitachi.com> (raw)
In-Reply-To: <54EC1487.4020902@rosalab.ru>

(2015/02/24 15:04), Eugene Shatokhin wrote:
> 24.02.2015 06:47, Masami Hiramatsu пишет:
>> No, that is not allowed. I mean, you can do anything you want to do
>> on your handler (enabling preemption/irq etc.) but the result may be
>> not safe (it can crash your kernel, but it's not a kprobes' bug).
> 
> Yes, that is why I am asking.
> 
>> Actually, enable interrupts on kprobe handlers can cause reentering
>> kprobes (by kprobes on interrupt handlers), and currently kprobe skips
>> all those reentered kprobes.
>> Is it acceptable that some of your kprobe handlers are not fired when
>> hitting?
> 
> I think, yes. When a software breakpoint hits, my system decodes the 
> instruction, finds the address that is about to be accessed and tries to 
> place a hardware breakpoint on that memory area.
> 
> There are only 4 hardware breakpoints a CPU can use on x86, so if the 
> software breakpoint hits too often, the system will not be able to 
> process all hits anyway because all HW breakpoints may be already in use.
> 
>> Would you mean sleep on your handler??
> 
> No, I use mdelay(). It is, in essence, a busy-wait loop as far as I 
> know. The delay intervals may vary, the default is 5 jiffies.

Hmm, here I couldn't understand. If mdelay() does busy-wait loop, why
would you like to enable irq??
Other code doesn't work on the core while waiting.

Thank you,


-- 
Masami HIRAMATSU
Software Platform Research Dept. Linux Technology Research Center
Hitachi, Ltd., Yokohama Research Laboratory
E-mail: masami.hiramatsu.pt@hitachi.com



  reply	other threads:[~2015-02-24 10:24 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-23 15:04 Kprobes: pre-handler with interrupts enabled - is it possible? Eugene Shatokhin
2015-02-24  3:47 ` Masami Hiramatsu
2015-02-24  6:04   ` Eugene Shatokhin
2015-02-24 10:24     ` Masami Hiramatsu [this message]
2015-03-09 11:04       ` Eugene Shatokhin
2015-03-22 17:26       ` Eugene Shatokhin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54EC5160.7090400@hitachi.com \
    --to=masami.hiramatsu.pt@hitachi.com \
    --cc=eugene.shatokhin@rosalab.ru \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox