From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753298AbbBXXlK (ORCPT ); Tue, 24 Feb 2015 18:41:10 -0500 Received: from lists.s-osg.org ([54.187.51.154]:38216 "EHLO lists.s-osg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753234AbbBXXlI (ORCPT ); Tue, 24 Feb 2015 18:41:08 -0500 Message-ID: <54ED0C0D.10704@osg.samsung.com> Date: Tue, 24 Feb 2015 16:41:01 -0700 From: Shuah Khan Organization: Samsung Open Source Group User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Mauro Carvalho Chehab CC: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] media: em28xx replace printk in dprintk macros References: <1424804027-7790-1-git-send-email-shuahkh@osg.samsung.com> <20150224190315.124b71f3@recife.lan> In-Reply-To: <20150224190315.124b71f3@recife.lan> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/24/2015 03:03 PM, Mauro Carvalho Chehab wrote: > Em Tue, 24 Feb 2015 11:53:47 -0700 > Shuah Khan escreveu: > >> Replace printk macro in dprintk macros in em28xx audio, dvb, >> and input files with pr_* equivalent routines. >> >> Signed-off-by: Shuah Khan >> --- >> drivers/media/usb/em28xx/em28xx-audio.c | 3 +-- >> drivers/media/usb/em28xx/em28xx-dvb.c | 2 +- >> drivers/media/usb/em28xx/em28xx-input.c | 2 +- >> 3 files changed, 3 insertions(+), 4 deletions(-) >> >> diff --git a/drivers/media/usb/em28xx/em28xx-audio.c b/drivers/media/usb/em28xx/em28xx-audio.c >> index 49a5f95..93d89f2 100644 >> --- a/drivers/media/usb/em28xx/em28xx-audio.c >> +++ b/drivers/media/usb/em28xx/em28xx-audio.c >> @@ -55,8 +55,7 @@ MODULE_PARM_DESC(debug, "activates debug info"); >> >> #define dprintk(fmt, arg...) do { \ >> if (debug) \ >> - printk(KERN_INFO "em28xx-audio %s: " fmt, \ >> - __func__, ##arg); \ >> + pr_info("em28xx-audio %s: " fmt, __func__, ##arg); \ >> } while (0) >> >> static int index[SNDRV_CARDS] = SNDRV_DEFAULT_IDX; >> diff --git a/drivers/media/usb/em28xx/em28xx-dvb.c b/drivers/media/usb/em28xx/em28xx-dvb.c >> index aee70d4..8826054 100644 >> --- a/drivers/media/usb/em28xx/em28xx-dvb.c >> +++ b/drivers/media/usb/em28xx/em28xx-dvb.c >> @@ -71,7 +71,7 @@ DVB_DEFINE_MOD_OPT_ADAPTER_NR(adapter_nr); >> >> #define dprintk(level, fmt, arg...) do { \ >> if (debug >= level) \ >> - printk(KERN_DEBUG "%s/2-dvb: " fmt, dev->name, ## arg); \ >> + pr_debug("%s/2-dvb: " fmt, dev->name, ## arg); \ >> } while (0) >> >> struct em28xx_dvb { >> diff --git a/drivers/media/usb/em28xx/em28xx-input.c b/drivers/media/usb/em28xx/em28xx-input.c >> index 4007356..e99108b 100644 >> --- a/drivers/media/usb/em28xx/em28xx-input.c >> +++ b/drivers/media/usb/em28xx/em28xx-input.c >> @@ -43,7 +43,7 @@ MODULE_PARM_DESC(ir_debug, "enable debug messages [IR]"); >> >> #define dprintk(fmt, arg...) \ >> if (ir_debug) { \ >> - printk(KERN_DEBUG "%s/ir: " fmt, ir->name , ## arg); \ >> + pr_debug("%s/ir: " fmt, ir->name, ## arg); \ > > NACK. > > This is the worse of two words, as it would require both to enable > each debug line via dynamic printk setting and to enable ir_debug. > Ah. I missed that. Sorry for the noise. -- Shuah -- Shuah Khan Sr. Linux Kernel Developer Open Source Innovation Group Samsung Research America (Silicon Valley) shuahkh@osg.samsung.com | (970) 217-8978