From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753370AbbBXXlw (ORCPT ); Tue, 24 Feb 2015 18:41:52 -0500 Received: from lists.s-osg.org ([54.187.51.154]:38220 "EHLO lists.s-osg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753303AbbBXXlj (ORCPT ); Tue, 24 Feb 2015 18:41:39 -0500 Message-ID: <54ED0C30.8000709@osg.samsung.com> Date: Tue, 24 Feb 2015 16:41:36 -0700 From: Shuah Khan Organization: Samsung Open Source Group User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Mauro Carvalho Chehab CC: hans.verkuil@cisco.com, prabhakar.csengg@gmail.com, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] media: au0828 replace printk KERN_DEBUG with pr_debug References: <1424804014-7743-1-git-send-email-shuahkh@osg.samsung.com> <20150224190346.4cf0b439@recife.lan> In-Reply-To: <20150224190346.4cf0b439@recife.lan> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/24/2015 03:03 PM, Mauro Carvalho Chehab wrote: > Em Tue, 24 Feb 2015 11:53:34 -0700 > Shuah Khan escreveu: > >> Replace printk KERN_DEBUG with pr_debug in dprintk macro >> defined in au0828.h >> >> Signed-off-by: Shuah Khan >> --- >> drivers/media/usb/au0828/au0828.h | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/media/usb/au0828/au0828.h b/drivers/media/usb/au0828/au0828.h >> index eb15187..e3e90ea 100644 >> --- a/drivers/media/usb/au0828/au0828.h >> +++ b/drivers/media/usb/au0828/au0828.h >> @@ -336,7 +336,7 @@ extern struct vb2_ops au0828_vbi_qops; >> >> #define dprintk(level, fmt, arg...)\ >> do { if (au0828_debug & level)\ >> - printk(KERN_DEBUG pr_fmt(fmt), ## arg);\ >> + pr_debug(pr_fmt(fmt), ## arg);\ > > NACK. > > This is the worse of two words, as it would require both to enable > each debug line via dynamic printk setting and to enable au0828_debug. > > Regards, > Mauro Ah. I missed that. Sorry for the noise. -- Shuah -- Shuah Khan Sr. Linux Kernel Developer Open Source Innovation Group Samsung Research America (Silicon Valley) shuahkh@osg.samsung.com | (970) 217-8978