From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753234AbbBYKew (ORCPT ); Wed, 25 Feb 2015 05:34:52 -0500 Received: from mailout2.samsung.com ([203.254.224.25]:50293 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752338AbbBYKeu (ORCPT ); Wed, 25 Feb 2015 05:34:50 -0500 X-AuditID: cbfee690-f79ab6d0000046f7-2c-54eda548ab0b Message-id: <54EDA548.40304@samsung.com> Date: Wed, 25 Feb 2015 19:34:48 +0900 From: Jaehoon Chung User-Agent: Mozilla/5.0 (X11; Linux i686; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-version: 1.0 To: Doug Anderson , Seungwon Jeon , Ulf Hansson Cc: Alim Akhtar , Sonny Rao , Andrew Bresticker , Heiko Stuebner , Addy Ke , Alexandru Stan , javier.martinez@collabora.co.uk, chris@printf.net, linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] mmc: dw_mmc: Make sure we only adjust the clock when power is on References: <1424458639-23330-1-git-send-email-dianders@chromium.org> In-reply-to: <1424458639-23330-1-git-send-email-dianders@chromium.org> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrLIsWRmVeSWpSXmKPExsWyRsSkUNdj6dsQgxULOC1Wvv/LaLHs/3cm iwfztrFZNLyYxGox4fJ2Rouzyw6yWfx/9JrV4ujvAovLu+awWRz5389o8eTMTEaLD/cvMlsc XxvuwOsxu+Eii8ff59dZPO5c28PmcePVQiaPv7P2s3j0bVnF6LH92jxmj8+b5AI4orhsUlJz MstSi/TtErgyPh3oZSlYKVBxe/tGxgbGHzxdjJwcEgImEs+fTWKEsMUkLtxbz9bFyMUhJLCU UeLlpy9MMEX/ni1iA7GFBKYzSsxu0oYoes0o8e3wChaQBK+AhsTnDUfAbBYBVYkbU28yg9hs AjoS278dBxskKhAmMfHmY1aIekGJH5PvgdWLCJRLzNnawwQylFngKpPEwcWnwE4SFoiWmLtq ByvEZleJU192gQ3iFHCTWLjtDVANB1CDnsT9i1ogYWYBeYnNa94yg8yREJjIIXHp2F1WiIME JL5NPsQCUi8hICux6QAzxGOSEgdX3GCZwCg2C8lJsxCmzkIydQEj8ypG0dSC5ILipPQiE73i xNzi0rx0veT83E2MwFg+/e/ZhB2M9w5YH2IU4GBU4uFNEH4TIsSaWFZcmXuI0RToiInMUqLJ +cCEkVcSb2hsZmRhamJqbGRuaaYkzvta6mewkEB6YklqdmpqQWpRfFFpTmrxIUYmDk6pBkbb fZvfPXx9KDZd5MvE7Vm2zt3af1fteKa1qWmCUXJ+d3ftHImQPJUwy5nJmm8NszKL48/VL72p nmx6SL2o4+OF7ymbzIJW+F091s7Q1Mpz8APru6c/vizffZinb/UzB07xC8srHp3L/FJ27/fl N55CQsUJb5fsP/FVOE7hmJat1HOjGhGzZHElluKMREMt5qLiRAAvBf6M4AIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprGKsWRmVeSWpSXmKPExsVy+t9jQV2PpW9DDJ5lWqx8/5fRYtn/70wW D+ZtY7NoeDGJ1WLC5e2MFmeXHWSz+P/oNavF0d8FFpd3zWGzOPK/n9HiyZmZjBYf7l9ktji+ NtyB12N2w0UWj7/Pr7N43Lm2h83jxquFTB5/Z+1n8ejbsorRY/u1ecwenzfJBXBENTDaZKQm pqQWKaTmJeenZOal2yp5B8c7x5uaGRjqGlpamCsp5CXmptoqufgE6Lpl5gBdrKRQlphTChQK SCwuVtK3wzQhNMRN1wKmMULXNyQIrsfIAA0krGHM+HSgl6VgpUDF7e0bGRsYf/B0MXJySAiY SPx7togNwhaTuHBvPZgtJDCdUWJ2k3YXIxeQ/ZpR4tvhFSwgCV4BDYnPG46A2SwCqhI3pt5k BrHZBHQktn87zgRiiwqESUy8+ZgVol5Q4sfke2D1IgLlEnO29jCBDGUWuMokcXDxKUaQhLBA tMTcVTtYITa7Spz6sgtsEKeAm8TCbW+AajiAGvQk7l/UAgkzC8hLbF7zlnkCo8AsJCtmIVTN QlK1gJF5FaNoakFyQXFSeq6RXnFibnFpXrpecn7uJkZwmngmvYNxVYPFIUYBDkYlHt5E4Tch QqyJZcWVuYcYJTiYlUR49898GyLEm5JYWZValB9fVJqTWnyI0RQYABOZpUST84EpLK8k3tDY xMzI0sjc0MLI2FxJnFfJvi1ESCA9sSQ1OzW1ILUIpo+Jg1OqgXFN4t0u9y9X/GbVHijg+3v0 TvD+H4ldr/lPvPCXm8O2/H9do8LKj/q/9Iplt+77v+T/PIXjvPMEN/1draAg+/uHYM6OMr6X Lws8/51fMVv7SdBHnkirim3c5ivTf0e/4748b9fUA/nLdp/cpXGY6YFpnsuCTRc9TzyL8LEz f/O/tNfrcERl/OT3SizFGYmGWsxFxYkAY4XC+CkDAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Doug. It makes sense. Looks good to me. Thanks! Acked-by: Jaehoon Chung Best Regards, Jaehoon Chung On 02/21/2015 03:57 AM, Doug Anderson wrote: > It appears that we can confuse things if we try to turn on the MMC > clock when the power is off. Adjust is so that we turn the clock on > (using dw_mci_setup_bus) after power is all the way on and we turn the > clock off before the power goes off. > > Signed-off-by: Doug Anderson > --- > drivers/mmc/host/dw_mmc.c | 16 ++++++++++------ > 1 file changed, 10 insertions(+), 6 deletions(-) > > diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c > index 4d2e3c2..43fcae1 100644 > --- a/drivers/mmc/host/dw_mmc.c > +++ b/drivers/mmc/host/dw_mmc.c > @@ -1101,12 +1101,6 @@ static void dw_mci_set_ios(struct mmc_host *mmc, struct mmc_ios *ios) > if (drv_data && drv_data->set_ios) > drv_data->set_ios(slot->host, ios); > > - /* Slot specific timing and width adjustment */ > - dw_mci_setup_bus(slot, false); > - > - if (slot->host->state == STATE_WAITING_CMD11_DONE && ios->clock != 0) > - slot->host->state = STATE_IDLE; > - > switch (ios->power_mode) { > case MMC_POWER_UP: > if (!IS_ERR(mmc->supply.vmmc)) { > @@ -1133,8 +1127,15 @@ static void dw_mci_set_ios(struct mmc_host *mmc, struct mmc_ios *ios) > else > slot->host->vqmmc_enabled = true; > } > + > + /* Adjust clock / bus width after power is up */ > + dw_mci_setup_bus(slot, false); > + > break; > case MMC_POWER_OFF: > + /* Turn clock off before power goes down */ > + dw_mci_setup_bus(slot, false); > + > if (!IS_ERR(mmc->supply.vmmc)) > mmc_regulator_set_ocr(mmc, mmc->supply.vmmc, 0); > > @@ -1150,6 +1151,9 @@ static void dw_mci_set_ios(struct mmc_host *mmc, struct mmc_ios *ios) > default: > break; > } > + > + if (slot->host->state == STATE_WAITING_CMD11_DONE && ios->clock != 0) > + slot->host->state = STATE_IDLE; > } > > static int dw_mci_card_busy(struct mmc_host *mmc) >