From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752900AbbBYKpl (ORCPT ); Wed, 25 Feb 2015 05:45:41 -0500 Received: from mail-we0-f180.google.com ([74.125.82.180]:35699 "EHLO mail-we0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752245AbbBYKpk (ORCPT ); Wed, 25 Feb 2015 05:45:40 -0500 Message-ID: <54EDA7D2.2040203@linaro.org> Date: Wed, 25 Feb 2015 11:45:38 +0100 From: Daniel Lezcano User-Agent: Mozilla/5.0 (X11; Linux i686; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Ingo Molnar CC: tglx@linutronix.de, matthias.bgg@gmail.com, robert.jarzmik@free.fr, linux@roeck-us.net, linux@rempel-privat.de, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/3] clocksource: pxa: Fix section mismatch References: <54EDA19F.7050903@linaro.org> <1424860276-18334-1-git-send-email-daniel.lezcano@linaro.org> <1424860276-18334-3-git-send-email-daniel.lezcano@linaro.org> <20150225103555.GC554@gmail.com> In-Reply-To: <20150225103555.GC554@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/25/2015 11:35 AM, Ingo Molnar wrote: > > * Daniel Lezcano wrote: > >> From: Robert Jarzmik >> >> As pxa_timer_common_init() is only called in init context, mark it as >> such, and quiesce the compiler warnings : >> WARNING: vmlinux.o(.text.unlikely+0x45d4): Section mismatch in reference >> from the function pxa_timer_common_init() to the function >> .init.text:sched_clock_register() >> >> WARNING: vmlinux.o(.text.unlikely+0x4610): Section mismatch in reference >> from the function pxa_timer_common_init() to the function >> .init.text:clocksource_mmio_init() >> >> Signed-off-by: Robert Jarzmik >> Signed-off-by: Daniel Lezcano >> --- >> drivers/clocksource/pxa_timer.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/clocksource/pxa_timer.c b/drivers/clocksource/pxa_timer.c >> index 941f3f3..d9438af 100644 >> --- a/drivers/clocksource/pxa_timer.c >> +++ b/drivers/clocksource/pxa_timer.c >> @@ -163,7 +163,7 @@ static struct irqaction pxa_ost0_irq = { >> .dev_id = &ckevt_pxa_osmr0, >> }; >> >> -static void pxa_timer_common_init(int irq, unsigned long clock_tick_rate) >> +static void __init pxa_timer_common_init(int irq, unsigned long clock_tick_rate) >> { >> timer_writel(0, OIER); >> timer_writel(OSSR_M0 | OSSR_M1 | OSSR_M2 | OSSR_M3, OSSR); > > So this is then used indirectly by: > > CLOCKSOURCE_OF_DECLARE(pxa_timer, "marvell,pxa-timer", pxa_timer_dt_init); > > which should probably be marked __initdata? Sorry, I miss the point. What should be marked __initdata ? -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog