From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753274AbbBYUny (ORCPT ); Wed, 25 Feb 2015 15:43:54 -0500 Received: from saturn.retrosnub.co.uk ([178.18.118.26]:37298 "EHLO saturn.retrosnub.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752657AbbBYUnv (ORCPT ); Wed, 25 Feb 2015 15:43:51 -0500 Message-ID: <54EDB82E.5050406@kernel.org> Date: Wed, 25 Feb 2015 11:55:26 +0000 From: Jonathan Cameron User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Krzysztof Kozlowski , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald , Greg Kroah-Hartman , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org Subject: Re: [PATCH 2/2] iio: jsa1212: Constify struct regmap_config References: <1424770909-7360-1-git-send-email-k.kozlowski@samsung.com> <1424770909-7360-2-git-send-email-k.kozlowski@samsung.com> In-Reply-To: <1424770909-7360-2-git-send-email-k.kozlowski@samsung.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 24/02/15 09:41, Krzysztof Kozlowski wrote: > The regmap_config struct may be const because it is not modified by the > driver and regmap_init() accepts pointer to const. > > Signed-off-by: Krzysztof Kozlowski Applied to the togreg branch of iio.git. I'm having another of my periodic days in a clean room (with a very dirty laptop), so will be a day or two before I'm back home and can push out as testing for the autobuilders to play. On the plus side, the machine I'm working on isn't running so lots of time for patch review... Jonathan > --- > drivers/iio/light/jsa1212.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/iio/light/jsa1212.c b/drivers/iio/light/jsa1212.c > index 29de7e7d9562..3a3af89beaf9 100644 > --- a/drivers/iio/light/jsa1212.c > +++ b/drivers/iio/light/jsa1212.c > @@ -308,7 +308,7 @@ static bool jsa1212_is_volatile_reg(struct device *dev, unsigned int reg) > } > } > > -static struct regmap_config jsa1212_regmap_config = { > +static const struct regmap_config jsa1212_regmap_config = { > .name = JSA1212_REGMAP_NAME, > .reg_bits = 8, > .val_bits = 8, >