public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Nikolai Kondrashov <spbnick@gmail.com>
To: Benjamin Tissoires <benjamin.tissoires@redhat.com>,
	Jiri Kosina <jkosina@suse.cz>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
	DIGImend-devel <DIGImend-devel@lists.sourceforge.net>
Subject: Re: [PATCH 1/4] HID: uclogic: Set quirks from inside the driver
Date: Wed, 25 Feb 2015 23:04:37 +0200	[thread overview]
Message-ID: <54EE38E5.5090209@gmail.com> (raw)
In-Reply-To: <1424822730-14938-2-git-send-email-benjamin.tissoires@redhat.com>

On 02/25/2015 02:05 AM, Benjamin Tissoires wrote:
> Based on a patch from: Nikolai Kondrashov <Nikolai.Kondrashov@redhat.com>
>
> Most of the tablets handled by hid-uclogic already uses MULTI_INPUT.

*use

> Fot the ones which are not quirked in usbhid/hidquirks, they have a

*For

> custom report descriptor which contains only one report per HID
> interface. For those tablets HID_QUIRK_MULTI_INPUT is transparent.
>
> According to https://github.com/DIGImend/tablets, the only problematic
> tablet currently handled by hid-uclogic is the TWHA60 v3. This tablet
> presents different report descriptors from the ones currently quirked.
> This is not a problem per se, given that this tablet is not supported
> currently in this version (it needs the same command than a Huion to

*as a Huion

> start forwarding events).

Thanks, Benjamin. this will make further merges easier.
Regardless of the Grammar Nazi comments above (fixing is up to you):

Reviewed-by: Nikolai Kondrashov <spbnick@gmail.com>

Nick

  reply	other threads:[~2015-02-25 21:04 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-25  0:05 [PATCH 0/4] HID: huion/uclogic merge and few additions Benjamin Tissoires
2015-02-25  0:05 ` [PATCH 1/4] HID: uclogic: Set quirks from inside the driver Benjamin Tissoires
2015-02-25 21:04   ` Nikolai Kondrashov [this message]
2015-02-25 21:23     ` Benjamin Tissoires
2015-02-25  0:05 ` [PATCH 2/4] HID: uclogic: merge hid-huion driver in hid-uclogic Benjamin Tissoires
2015-02-25 21:04   ` Nikolai Kondrashov
2015-02-25 21:28     ` Benjamin Tissoires
2015-02-25 22:23       ` Nikolai Kondrashov
2015-02-25  0:05 ` [PATCH 3/4] HID: uclogic: present only the working interfaces on the Huion tablets Benjamin Tissoires
2015-02-25 21:04   ` Nikolai Kondrashov
2015-02-25 21:30     ` Benjamin Tissoires
2015-02-26 17:02       ` Benjamin Tissoires
2015-02-25  0:05 ` [PATCH 4/4] HID: uclogic: name the input nodes based on their tool Benjamin Tissoires
2015-02-25 21:04   ` Nikolai Kondrashov
2015-02-25 21:36     ` Benjamin Tissoires
2015-02-25 22:28       ` Nikolai Kondrashov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54EE38E5.5090209@gmail.com \
    --to=spbnick@gmail.com \
    --cc=DIGImend-devel@lists.sourceforge.net \
    --cc=benjamin.tissoires@redhat.com \
    --cc=jkosina@suse.cz \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox