From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753068AbbBZDcC (ORCPT ); Wed, 25 Feb 2015 22:32:02 -0500 Received: from szxga01-in.huawei.com ([119.145.14.64]:25145 "EHLO szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752666AbbBZDcA (ORCPT ); Wed, 25 Feb 2015 22:32:00 -0500 Message-ID: <54EE9389.9090609@huawei.com> Date: Thu, 26 Feb 2015 11:31:21 +0800 From: "long.wanglong" User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:16.0) Gecko/20121010 Thunderbird/16.0.1 MIME-Version: 1.0 To: Andy Shevchenko CC: , , Subject: Re: [PATCH] test-hexdump: test the return value of the hex_dump_to_buffer References: <1423993813-218469-1-git-send-email-long.wanglong@huawei.com> <1424080072.31903.557.camel@linux.intel.com> In-Reply-To: <1424080072.31903.557.camel@linux.intel.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.111.88.174] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2015/2/16 17:47, Andy Shevchenko wrote: > On Sun, 2015-02-15 at 09:50 +0000, Wang Long wrote: >> As the function hex_dump_to_buffer returns the amount of bytes placed >> in the buffer without terminating NUL. the test-hexdump should test >> the return value of it. > > I don't think it's needed. When the prototype was changed the new test > case had been introduced to cover the overflow cases, i.e. > test_hexdump_overflow(). > ok, thanks. >> >> Signed-off-by: Wang Long >> --- >> lib/test-hexdump.c | 5 +++-- >> 1 file changed, 3 insertions(+), 2 deletions(-) >> >> diff --git a/lib/test-hexdump.c b/lib/test-hexdump.c >> index daf29a39..9243be7 100644 >> --- a/lib/test-hexdump.c >> +++ b/lib/test-hexdump.c >> @@ -52,8 +52,9 @@ static void __init test_hexdump(size_t len, int rowsize, int groupsize, >> size_t l = len; >> int gs = groupsize, rs = rowsize; >> unsigned int i; >> + int r; >> >> - hex_dump_to_buffer(data_b, l, rs, gs, real, sizeof(real), ascii); >> + r = hex_dump_to_buffer(data_b, l, rs, gs, real, sizeof(real), ascii); >> >> if (rs != 16 && rs != 32) >> rs = 16; >> @@ -96,7 +97,7 @@ static void __init test_hexdump(size_t len, int rowsize, int groupsize, >> >> *p = '\0'; >> >> - if (strcmp(test, real)) { >> + if (strcmp(test, real) || r != strlen(real)) { >> pr_err("Len: %zu row: %d group: %d\n", len, rowsize, groupsize); >> pr_err("Result: '%s'\n", real); >> pr_err("Expect: '%s'\n", test); > >