From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932242AbbBZI2R (ORCPT ); Thu, 26 Feb 2015 03:28:17 -0500 Received: from mailout2.samsung.com ([203.254.224.25]:54832 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751873AbbBZI2P (ORCPT ); Thu, 26 Feb 2015 03:28:15 -0500 X-AuditID: cbfee68e-f79b46d000002b74-2f-54eed9115a7a Message-id: <54EED910.4010603@samsung.com> Date: Thu, 26 Feb 2015 17:28:00 +0900 From: Chanwoo Choi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130106 Thunderbird/17.0.2 MIME-version: 1.0 To: Arnd Bergmann , kgene@kernel.org, Sylwester Nawrocki Cc: mark.rutland@arm.com, marc.zyngier@arm.com, olof@lixom.net, catalin.marinas@arm.com, will.deacon@arm.com, inki.dae@samsung.com, chanho61.park@samsung.com, sw0312.kim@samsung.com, jh80.chung@samsung.com, ideal.song@samsung.com, a.kesavan@samsung.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel Subject: Re: [PATCH v4 1/8] arm64: exynos5433: Enable ARMv8 based Exynos5433 (SoC) support References: <1424755011-15999-1-git-send-email-cw00.choi@samsung.com> <1424755011-15999-2-git-send-email-cw00.choi@samsung.com> <8838911.kfOYZxBsJP@wuerfel> In-reply-to: <8838911.kfOYZxBsJP@wuerfel> Content-type: text/plain; charset=ISO-8859-1 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrMIsWRmVeSWpSXmKPExsWyRsSkUFfw5rsQg2mr2S0er1nMZPF30jF2 i/fLehgtLu/Xtph/5Byrxa6/9xktJt2fwGJx41cbq0X/49fMFpseX2O1uLxrDpvFjPP7gLru /GOzWHr9IpPFqeuf2SwOv2lntZgx+SWbxcuPJ1gchDzWzFvD6PH71yRGj02rOtk8Ni+p97hy oonVo2/LKkaPz5vkAtijuGxSUnMyy1KL9O0SuDL+bHAqeMZf8XjJfuYGxvs8XYycHBICJhJ7 n01ggrDFJC7cW8/WxcjFISSwlFHi9PHpjDBFp581QCUWMUqcvLYMynnNKHG9oYkFpIpXQEui 63krG4jNIqAqceTnM2YQmw0ovv/FDbC4qECYxMrpV6DqBSV+TL4HZosIJElc+X4QbCizwAxm ias/WsESwgIxEt8vPGOF2LaAUWLr0QOsIAlOAU2J67cPgh3OLKAjsb91GhuELS+xec1bZoi7 F3JI/FnqA3GRgMS3yYeAhnIAxWUlNh2AKpGUOLjiBssERrFZSG6ahWTqLCRTFzAyr2IUTS1I LihOSi8y0itOzC0uzUvXS87P3cQIjPvT/5717WC8ecD6EKMAB6MSD29C9rsQIdbEsuLK3EOM pkBXTGSWEk3OByaXvJJ4Q2MzIwtTE1NjI3NLMyVx3gSpn8FCAumJJanZqakFqUXxRaU5qcWH GJk4OKUaGHXfFK87L7zqvGOHydVQ15RZUwp2dRW6bDsmJ+6vc/ufy/X2/yeF5jxIDBTRYIzq 6bZkeneAzTXp3RrpYMv454sOZTs9+HXwnsWJ7OI9S91n3J3OFR7/po933sV/fB+qN1m8ybie mqEmuto7zO6YdkLUGxW/hK3TuqqOvLp3WXfuBa0trC8E4pVYijMSDbWYi4oTARijSk32AgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrHKsWRmVeSWpSXmKPExsVy+t9jAV2Bm+9CDF6usLJ4vGYxk8XfScfY Ld4v62G0uLxf22L+kXOsFrv+3me0mHR/AovFjV9trBb9j18zW2x6fI3V4vKuOWwWM87vA+q6 84/NYun1i0wWp65/ZrM4/Kad1WLG5JdsFi8/nmBxEPJYM28No8fvX5MYPTat6mTz2Lyk3uPK iSZWj74tqxg9Pm+SC2CPamC0yUhNTEktUkjNS85PycxLt1XyDo53jjc1MzDUNbS0MFdSyEvM TbVVcvEJ0HXLzAF6Q0mhLDGnFCgUkFhcrKRvh2lCaIibrgVMY4Sub0gQXI+RARpIWMOY8WeD U8Ez/orHS/YzNzDe5+li5OSQEDCROP2sgQ3CFpO4cG89kM3FISSwiFHi5LVlUM5rRonrDU0s IFW8AloSXc9bwTpYBFQljvx8xgxiswHF97+4ARYXFQiTWDn9ClS9oMSPyffAbBGBJIkr3w+C DWUWmMEscfVHK1hCWCBG4vuFZ6wQ2xYwSmw9eoAVJMEpoClx/fZBJhCbWUBHYn/rNDYIW15i 85q3zBMYBWYhWTILSdksJGULGJlXMYqmFiQXFCel5xrqFSfmFpfmpesl5+duYgSnlWdSOxhX NlgcYhTgYFTi4U3IfhcixJpYVlyZe4hRgoNZSYT37DGgEG9KYmVValF+fFFpTmrxIUZTYBhM ZJYSTc4Hpry8knhDYxMzI0sjc0MLI2NzJXFeJfu2ECGB9MSS1OzU1ILUIpg+Jg5OqQbGxQ2N n/4rSQkm6v7/xbplmZXv7ZdPtj3cXvtph2nSHguJ70wm4t/Yzu+sbK5ROVGlILX3rFPYgoYD bf+d7KZ7ZUTWvUiYMPlt4RyX69s9Wh8Wr1kevlE4+uHRw04m1feE0zK33jp79sy6666VYlFa x5sNtsp4pS7pDXGcJasz/XPJBOu3VjNjlViKMxINtZiLihMB2adDwEEDAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/24/2015 05:31 PM, Arnd Bergmann wrote: > On Tuesday 24 February 2015 14:16:44 Chanwoo Choi wrote: >> diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig >> index 1b8e973..d83cea0 100644 >> --- a/arch/arm64/Kconfig >> +++ b/arch/arm64/Kconfig >> @@ -154,6 +154,17 @@ config ARCH_EXYNOS >> help >> This enables support for Samsung Exynos SoC family >> >> +config ARCH_EXYNOS5433 >> + bool "ARMv8 based Samsung Exynos5433" >> + select ARCH_EXYNOS >> + select COMMON_CLK_SAMSUNG >> + select HAVE_S3C_RTC if RTC_CLASS >> + select PINCTRL >> + select PINCTRL_EXYNOS >> + >> + help >> + This enables support for Samsung Exynos5433 SoC family >> + >> config ARCH_EXYNOS7 >> bool "ARMv8 based Samsung Exynos7" >> select ARCH_EXYNOS >> -- >> > > Can we collapse all these entries into one for EXYNOS? I don't > want to end up with endless lists like we have on arm32 when > there is no platform specific code that is actually controlled > by this anway. I agree. I check the some issue for only using the CONFIG_ARCH_EXYNOS insead of CONFIG_ARCH_EXYNOS7 and CONFIG_ARCH_EXYNOS5433. Each CONFIG_ARCH_EXYNOS{7|5433} configuraiton was used on following list: - CONFIG_ARCH_EXYNOS7 arch/arm64/boot/dts/exynos/Makefile:1:dtb-$(CONFIG_ARCH_EXYNOS7) += exynos7-espresso.dtb drivers/clk/samsung/Makefile:17:obj-$(CONFIG_ARCH_EXYNOS7) += clk-exynos7.o - CONFIG_ARCH_EXYNOS5433 drivers/clk/samsung/Makefile:13:obj-$(CONFIG_ARCH_EXYNOS5433) += clk-exynos5433.o We may can fix it as following by only using 'CONFIG_ARCH_EXYNOS' without any specific configuration. arch/arm64/boot/dts/exynos/Makefile:1:dtb-$(CONFIG_ARCH_EXYNOS) += exynos7-espresso.dtb drivers/clk/samsung/Makefile:17:obj-$(CONFIG_ARCH_EXYNOS) += clk-exynos7.o clk-exynos5433.o I think that we need the opinion of Kukjin Kim (Exynos SoC Maintainer) and Sylwester Nawrocki(Samsung clock Maintainer) Thanks, Chanwoo Choi