From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753580AbbBZKYz (ORCPT ); Thu, 26 Feb 2015 05:24:55 -0500 Received: from service87.mimecast.com ([91.220.42.44]:36828 "EHLO service87.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753299AbbBZKYx convert rfc822-to-8bit (ORCPT ); Thu, 26 Feb 2015 05:24:53 -0500 Message-ID: <54EEF475.5080107@arm.com> Date: Thu, 26 Feb 2015 10:24:53 +0000 From: Sudeep Holla User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Laurent Pinchart CC: Sudeep Holla , Felipe Balbi , "linux-kernel@vger.kernel.org" , "linux-usb@vger.kernel.org" , Greg Kroah-Hartman Subject: Re: [PATCH] usb: isp1760: fix peripheral/device controller chip id References: <1424800422-25332-1-git-send-email-sudeep.holla@arm.com> <7662882.E4UNjpCumE@avalon> In-Reply-To: <7662882.E4UNjpCumE@avalon> X-OriginalArrivalTime: 26 Feb 2015 10:24:50.0153 (UTC) FILETIME=[73BADD90:01D051AE] X-MC-Unique: 115022610245100301 Content-Type: text/plain; charset=WINDOWS-1252; format=flowed Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Laurent, On 25/02/15 22:27, Laurent Pinchart wrote: > Hi Sudeep, > > Thank you for the patch. > > On Tuesday 24 February 2015 17:53:42 Sudeep Holla wrote: >> As per the ISP1761 data sheet, the DcChipID register represents >> the hardware version number (0015h) and the chip ID (8210h) for the >> Peripheral Controller. >> >> This patch fixes the chip ID value used to verify the controller. >> >> Cc: Felipe Balbi >> Cc: Laurent Pinchart >> Signed-off-by: Sudeep Holla >> --- >> drivers/usb/isp1760/isp1760-udc.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> Hi Laurent, >> >> I found that the chip ID is wrong when I tried testing OTG on vexpress >> platforms. As per Section 10.8.2 DcChipID register in [1], it should be >> 0x00158210. > > On the other hand, http://www.nxp.com/documents/data_sheet/SAF1761.pdf#120 > uses 0x00011582. It looks like we need to accept both. > Thanks for sharing this datasheet, I will update to accept both ID and resend. Regards, Sudeep