* [PATCH] loongson-3/hpet.c: remove IRQF_DISABLED flag
@ 2015-02-27 12:14 Valentin Rothberg
2015-02-27 12:47 ` Sergei Shtylyov
2015-02-27 13:38 ` [PATCH v2] " Valentin Rothberg
0 siblings, 2 replies; 3+ messages in thread
From: Valentin Rothberg @ 2015-02-27 12:14 UTC (permalink / raw)
To: ralf, taohl, chenhc, linux-mips, linux-kernel; +Cc: Valentin Rothberg
The IRQF_DISABLED is a NOOP and scheduled to be removed. According to Ingo
Molnar (e58aa3d2d0cc01ad8d6f7f640a0670433f794922) running IRQ handlers with
interrupts enabled can cause stack overflows when the interrupt line of the
issuing device is still active.
Signed-off-by: Valentin Rothberg <Valentin.Rothberg@lip6.fr>
---
arch/mips/loongson/loongson-3/hpet.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/mips/loongson/loongson-3/hpet.c b/arch/mips/loongson/loongson-3/hpet.c
index e898d68..5c21cd3 100644
--- a/arch/mips/loongson/loongson-3/hpet.c
+++ b/arch/mips/loongson/loongson-3/hpet.c
@@ -162,7 +162,7 @@ static irqreturn_t hpet_irq_handler(int irq, void *data)
static struct irqaction hpet_irq = {
.handler = hpet_irq_handler,
- .flags = IRQF_DISABLED | IRQF_NOBALANCING | IRQF_TIMER,
+ .flags = IRQF_NOBALANCING | IRQF_TIMER,
.name = "hpet",
};
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] loongson-3/hpet.c: remove IRQF_DISABLED flag
2015-02-27 12:14 [PATCH] loongson-3/hpet.c: remove IRQF_DISABLED flag Valentin Rothberg
@ 2015-02-27 12:47 ` Sergei Shtylyov
2015-02-27 13:38 ` [PATCH v2] " Valentin Rothberg
1 sibling, 0 replies; 3+ messages in thread
From: Sergei Shtylyov @ 2015-02-27 12:47 UTC (permalink / raw)
To: Valentin Rothberg, ralf, taohl, chenhc, linux-mips, linux-kernel
Hello.
On 2/27/2015 3:14 PM, Valentin Rothberg wrote:
> The IRQF_DISABLED is a NOOP and scheduled to be removed. According to Ingo
> Molnar (e58aa3d2d0cc01ad8d6f7f640a0670433f794922) running IRQ handlers with
Please also specify that commit's summary line in parens, like this:
According to commit e58aa3d2d0cc01ad8d6f7f640a0670433f794922 (genirq: Run irq
handlers with interrupts disabled)...
> interrupts enabled can cause stack overflows when the interrupt line of the
> issuing device is still active.
> Signed-off-by: Valentin Rothberg <Valentin.Rothberg@lip6.fr>
[...]
WBR, Sergei
^ permalink raw reply [flat|nested] 3+ messages in thread* [PATCH v2] loongson-3/hpet.c: remove IRQF_DISABLED flag
2015-02-27 12:14 [PATCH] loongson-3/hpet.c: remove IRQF_DISABLED flag Valentin Rothberg
2015-02-27 12:47 ` Sergei Shtylyov
@ 2015-02-27 13:38 ` Valentin Rothberg
1 sibling, 0 replies; 3+ messages in thread
From: Valentin Rothberg @ 2015-02-27 13:38 UTC (permalink / raw)
To: ralf, taohl, chenhc, linux-mips, linux-kernel, sergei.shtylyov
Cc: Valentin Rothberg
The IRQF_DISABLED is a NOOP and scheduled to be removed. According to
commit e58aa3d2d0cc (genirq: Run irq handlers with interrupts disabled)
running IRQ handlers with interrupts enabled can cause stack overflows
when the interrupt line of the issuing device is still active.
Signed-off-by: Valentin Rothberg <Valentin.Rothberg@lip6.fr>
---
v2: Add commit summary of referenced commit.
---
arch/mips/loongson/loongson-3/hpet.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/mips/loongson/loongson-3/hpet.c b/arch/mips/loongson/loongson-3/hpet.c
index e898d68..5c21cd3 100644
--- a/arch/mips/loongson/loongson-3/hpet.c
+++ b/arch/mips/loongson/loongson-3/hpet.c
@@ -162,7 +162,7 @@ static irqreturn_t hpet_irq_handler(int irq, void *data)
static struct irqaction hpet_irq = {
.handler = hpet_irq_handler,
- .flags = IRQF_DISABLED | IRQF_NOBALANCING | IRQF_TIMER,
+ .flags = IRQF_NOBALANCING | IRQF_TIMER,
.name = "hpet",
};
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-02-27 13:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-02-27 12:14 [PATCH] loongson-3/hpet.c: remove IRQF_DISABLED flag Valentin Rothberg
2015-02-27 12:47 ` Sergei Shtylyov
2015-02-27 13:38 ` [PATCH v2] " Valentin Rothberg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox