public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Lars-Peter Clausen <lars@metafoo.de>
To: Gabriel Dobato <dobatog@gmail.com>,
	Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
	linux-arm-kernel@lists.infradead.org
Cc: moinejf@free.fr, Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
	Takashi Iwai <tiwai@suse.de>, Max Filippov <jcmvbkbc@gmail.com>,
	Xiubo Li <Li.Xiubo@freescale.com>,
	alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] ARM: TLV320AIC23 SoC Audio Codec: Fix errors reported related to input routing signals.
Date: Fri, 27 Feb 2015 14:16:40 +0100	[thread overview]
Message-ID: <54F06E38.5020608@metafoo.de> (raw)
In-Reply-To: <1424950347-26241-1-git-send-email-dobatog@gmail.com>

On 02/26/2015 12:32 PM, Gabriel Dobato wrote:
> From: dobatog <dobatog@gmail.com>
>
> The following patch, based on stable v3.19,  corrects the errors that are reported in the boot trace in reference to the Input Signals of the audio codec TLV320AIC23:
>
> tlv320aic23-codec 1-001a: Control not supported for path LLINEIN -> [NULL] -> Line Input
> tlv320aic23-codec 1-001a: ASoC: no dapm match for LLINEIN --> NULL --> Line Input
> tlv320aic23-codec 1-001a: ASoC: Failed to add route LLINEIN -> NULL -> Line Input
> tlv320aic23-codec 1-001a: Control not supported for path RLINEIN -> [NULL] -> Line Input
> tlv320aic23-codec 1-001a: ASoC: no dapm match for RLINEIN --> NULL --> Line Input
> tlv320aic23-codec 1-001a: ASoC: Failed to add route RLINEIN -> NULL -> Line Input
> tlv320aic23-codec 1-001a: Control not supported for path MICIN -> [NULL] -> Mic Input
> tlv320aic23-codec 1-001a: ASoC: no dapm match for MICIN --> NULL --> Mic Input
> tlv320aic23-codec 1-001a: ASoC: Failed to add route MICIN -> NULL -> Mic Input
>
> I am trying to set the sound system in a CM-510 (Compulab - SoM) based board with DT, using Simple-Card-Audio and  the TLV320AIC23 audio codec included in the SoM . I faced this problem and thanks to the help of Sebastian Hesselbarth who noticed the possible error located in the structure snd_soc_dapm_route tlv320aic23_intercon[] , now errors are not reported.
>
> Tested on CM-510 (Compulab SoM Board).
>
> Signed-off-by: dobatog <dobatog@gmail.com>

Hi,

The patch itself looks good, but the commit message needs some work.

The subject line should be something like "ASoC: tlv320aic23: ..." to 
indicate that this is for the ASoC subsystem and the tlv320aic23 driver.

The commit message should be line-wrapped at around 76 characters.

Signed-off-by and From tag need to have your full name.

- Lars

      parent reply	other threads:[~2015-02-27 13:16 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-26 11:32 [PATCH 1/1] ARM: TLV320AIC23 SoC Audio Codec: Fix errors reported related to input routing signals Gabriel Dobato
2015-02-26 11:52 ` Max Filippov
2015-02-27 13:16 ` Lars-Peter Clausen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54F06E38.5020608@metafoo.de \
    --to=lars@metafoo.de \
    --cc=Li.Xiubo@freescale.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=dobatog@gmail.com \
    --cc=jcmvbkbc@gmail.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=moinejf@free.fr \
    --cc=perex@perex.cz \
    --cc=sebastian.hesselbarth@gmail.com \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox