From: Sylwester Nawrocki <s.nawrocki@samsung.com>
To: Axel Lin <axel.lin@ingics.com>
Cc: Kishon Vijay Abraham I <kishon@ti.com>,
Sylwester Nawrocki <sylvester.nawrocki@gmail.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
"linux-samsung-soc@vger.kernel.org"
<linux-samsung-soc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH RFT] phy: exynos-mipi-video: Use spin_lock to protct state->regmap rmw operations
Date: Fri, 27 Feb 2015 14:27:44 +0100 [thread overview]
Message-ID: <54F070D0.2050504@samsung.com> (raw)
In-Reply-To: <1425009057.12126.1.camel@phoenix>
On 27/02/15 04:50, Axel Lin wrote:
> he state->regmap is initialized by devm_regmap_init_mmio().
> So it's fine to use spin_lock rather than mutex to protct state->regmap rmw
> operations.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
> Hi Sylwester,
> I don't have this hardware handy, so can you test if this patch works.
> This patch is on top of my previous patch (phy: exynos-mipi-video: Fixup
> the test for state->regmap)
Thanks for the patch, it looks good to me. I somehow missed the syscon
already uses a spinlock for regmap protection.
v4.0-rc1 seems devastated as far as exynos4 is concerned, it may take
some time until I get around and fix all the issues so I tested your
patch on v3.19. It all works well as expected.
Acked-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
Tested-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
--
Thanks,
Sylwester
next prev parent reply other threads:[~2015-02-27 13:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-27 3:50 [PATCH RFT] phy: exynos-mipi-video: Use spin_lock to protct state->regmap rmw operations Axel Lin
2015-02-27 13:27 ` Sylwester Nawrocki [this message]
2015-03-04 12:24 ` Kishon Vijay Abraham I
2015-03-04 12:47 ` Sylwester Nawrocki
2015-03-04 12:53 ` Kishon Vijay Abraham I
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54F070D0.2050504@samsung.com \
--to=s.nawrocki@samsung.com \
--cc=axel.lin@ingics.com \
--cc=kishon@ti.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=sylvester.nawrocki@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox