From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753209AbbB0N16 (ORCPT ); Fri, 27 Feb 2015 08:27:58 -0500 Received: from mailout2.w1.samsung.com ([210.118.77.12]:64226 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751334AbbB0N15 (ORCPT ); Fri, 27 Feb 2015 08:27:57 -0500 X-AuditID: cbfec7f5-b7fc86d0000066b7-00-54f07045aa0e Message-id: <54F070D0.2050504@samsung.com> Date: Fri, 27 Feb 2015 14:27:44 +0100 From: Sylwester Nawrocki User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.1.2 MIME-version: 1.0 To: Axel Lin Cc: Kishon Vijay Abraham I , Sylwester Nawrocki , Kyungmin Park , "linux-samsung-soc@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH RFT] phy: exynos-mipi-video: Use spin_lock to protct state->regmap rmw operations References: <1425009057.12126.1.camel@phoenix> In-reply-to: <1425009057.12126.1.camel@phoenix> Content-type: text/plain; charset=utf-8 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrCLMWRmVeSWpSXmKPExsVy+t/xK7quBR9CDD6sU7Y4Mucrs8WFpz1s Fmeb3rBbXN41h81ixvl9TBbzPu9kcmDz2DnrLrtH288yj74tqxg9jt/YzuTxeZNcAGsUl01K ak5mWWqRvl0CV8bBvfuYCzrZK9qvaTYw3mHtYuTkkBAwkZi9YRMThC0mceHeerYuRi4OIYGl jBIvzv9jhnA+MUpMvLOcEaSKV0BLYta1pWAdLAKqEp/PPwOLswkYSvQe7QOzRQUiJE7e3cMO US8o8WPyPRYQW0RASWLV/cssIEOZBWYwSeyfNQ1oAweHsEC6xIfveiCmkICexPFj6SDlnAL6 EmufrWUBCTMLqEtMmZILEmYWkJfYvOYt8wRGgVlIFsxCqJqFpGoBI/MqRtHU0uSC4qT0XCO9 4sTc4tK8dL3k/NxNjJCQ/rqDcekxq0OMAhyMSjy8HhIfQoRYE8uKK3MPMUpwMCuJ8J7PAArx piRWVqUW5ccXleakFh9iZOLglGpglJmpLPxftic4eqXtYYGH1mExe/hcXsdnbpzCpnY5Weqt gEi31PHU1SWNsu9fLm1fZR/ezX/2zKtzAS5eRyW1N1+fz/TEVcJ3TlyfFTsbT5jpwtPbKvdc 6lDgjlGeeqjmZ1V71p0fNoF57y9rxrnpiPdUPd22ZtYXSadU1Rcz2C/daZaoyDuixFKckWio xVxUnAgA/4j0REcCAAA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 27/02/15 04:50, Axel Lin wrote: > he state->regmap is initialized by devm_regmap_init_mmio(). > So it's fine to use spin_lock rather than mutex to protct state->regmap rmw > operations. > > Signed-off-by: Axel Lin > --- > Hi Sylwester, > I don't have this hardware handy, so can you test if this patch works. > This patch is on top of my previous patch (phy: exynos-mipi-video: Fixup > the test for state->regmap) Thanks for the patch, it looks good to me. I somehow missed the syscon already uses a spinlock for regmap protection. v4.0-rc1 seems devastated as far as exynos4 is concerned, it may take some time until I get around and fix all the issues so I tested your patch on v3.19. It all works well as expected. Acked-by: Sylwester Nawrocki Tested-by: Sylwester Nawrocki -- Thanks, Sylwester