* [PATCH] phy: exynos-dp-video: Kill exynos_dp_video_phy_pwr_isol function
@ 2015-02-27 4:34 Axel Lin
2015-02-27 13:44 ` Sylwester Nawrocki
0 siblings, 1 reply; 2+ messages in thread
From: Axel Lin @ 2015-02-27 4:34 UTC (permalink / raw)
To: Kishon Vijay Abraham I
Cc: Jingoo Han, linux-kernel, linux-samsung-soc@vger.kernel.org
If IS_ERR(state->regs) the .probe fails.
So IS_ERR(state->regs) test in exynos_dp_video_phy_pwr_isol() is not necessary.
exynos_dp_video_phy_pwr_isol() simply does a regmap_update_bits() call now,
just call regmap_update_bits() instead and return proper return value.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
drivers/phy/phy-exynos-dp-video.c | 24 ++++--------------------
1 file changed, 4 insertions(+), 20 deletions(-)
diff --git a/drivers/phy/phy-exynos-dp-video.c b/drivers/phy/phy-exynos-dp-video.c
index f86cbe6..179cbf9 100644
--- a/drivers/phy/phy-exynos-dp-video.c
+++ b/drivers/phy/phy-exynos-dp-video.c
@@ -30,28 +30,13 @@ struct exynos_dp_video_phy {
const struct exynos_dp_video_phy_drvdata *drvdata;
};
-static void exynos_dp_video_phy_pwr_isol(struct exynos_dp_video_phy *state,
- unsigned int on)
-{
- unsigned int val;
-
- if (IS_ERR(state->regs))
- return;
-
- val = on ? 0 : EXYNOS5_PHY_ENABLE;
-
- regmap_update_bits(state->regs, state->drvdata->phy_ctrl_offset,
- EXYNOS5_PHY_ENABLE, val);
-}
-
static int exynos_dp_video_phy_power_on(struct phy *phy)
{
struct exynos_dp_video_phy *state = phy_get_drvdata(phy);
/* Disable power isolation on DP-PHY */
- exynos_dp_video_phy_pwr_isol(state, 0);
-
- return 0;
+ return regmap_update_bits(state->regs, state->drvdata->phy_ctrl_offset,
+ EXYNOS5_PHY_ENABLE, EXYNOS5_PHY_ENABLE);
}
static int exynos_dp_video_phy_power_off(struct phy *phy)
@@ -59,9 +44,8 @@ static int exynos_dp_video_phy_power_off(struct phy *phy)
struct exynos_dp_video_phy *state = phy_get_drvdata(phy);
/* Enable power isolation on DP-PHY */
- exynos_dp_video_phy_pwr_isol(state, 1);
-
- return 0;
+ return regmap_update_bits(state->regs, state->drvdata->phy_ctrl_offset,
+ EXYNOS5_PHY_ENABLE, 0);
}
static struct phy_ops exynos_dp_video_phy_ops = {
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] phy: exynos-dp-video: Kill exynos_dp_video_phy_pwr_isol function
2015-02-27 4:34 [PATCH] phy: exynos-dp-video: Kill exynos_dp_video_phy_pwr_isol function Axel Lin
@ 2015-02-27 13:44 ` Sylwester Nawrocki
0 siblings, 0 replies; 2+ messages in thread
From: Sylwester Nawrocki @ 2015-02-27 13:44 UTC (permalink / raw)
To: Axel Lin, Kishon Vijay Abraham I
Cc: Jingoo Han, linux-kernel, linux-samsung-soc@vger.kernel.org
On 27/02/15 05:34, Axel Lin wrote:
> If IS_ERR(state->regs) the .probe fails.
> So IS_ERR(state->regs) test in exynos_dp_video_phy_pwr_isol() is not necessary.
> exynos_dp_video_phy_pwr_isol() simply does a regmap_update_bits() call now,
> just call regmap_update_bits() instead and return proper return value.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
Reviewed-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-02-27 13:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-02-27 4:34 [PATCH] phy: exynos-dp-video: Kill exynos_dp_video_phy_pwr_isol function Axel Lin
2015-02-27 13:44 ` Sylwester Nawrocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox