From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753143AbbB0NpE (ORCPT ); Fri, 27 Feb 2015 08:45:04 -0500 Received: from mailout2.w1.samsung.com ([210.118.77.12]:65224 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752470AbbB0NpB (ORCPT ); Fri, 27 Feb 2015 08:45:01 -0500 X-AuditID: cbfec7f4-b7f126d000001e9a-af-54f0744a306e Message-id: <54F074D1.50904@samsung.com> Date: Fri, 27 Feb 2015 14:44:49 +0100 From: Sylwester Nawrocki User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.1.2 MIME-version: 1.0 To: Axel Lin , Kishon Vijay Abraham I Cc: Jingoo Han , linux-kernel@vger.kernel.org, "linux-samsung-soc@vger.kernel.org" Subject: Re: [PATCH] phy: exynos-dp-video: Kill exynos_dp_video_phy_pwr_isol function References: <1425011650.23256.1.camel@phoenix> In-reply-to: <1425011650.23256.1.camel@phoenix> Content-type: text/plain; charset=utf-8 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrLLMWRmVeSWpSXmKPExsVy+t/xq7peJR9CDDoXC1scmfOV2eLywkus Fhee9rBZXN41h81ixvl9TA6sHm0/yzz6tqxi9Dh+YzuTx+dNcgEsUVw2Kak5mWWpRfp2CVwZ +/5+YyxYz1zR+WQqYwPjR6YuRk4OCQETieNnL7JD2GISF+6tZ+ti5OIQEljKKPF22wEo5xOj xM5b71hAqngFNCTmv1sG1sEioCqxq+MuI4jNJmAo0Xu0D8wWFYiQOHl3DztEvaDEj8n3wHpF BLwkljWdYQEZyizQyyhx7/lHsISwQLjExNfTwGwhAT2J030HwGxOAX2Jyd//ANkcQA3qElOm 5IKEmQXkJTavecs8gVFgFpIVsxCqZiGpWsDIvIpRNLU0uaA4KT3XUK84Mbe4NC9dLzk/dxMj JIi/7GBcfMzqEKMAB6MSD6+D4IcQIdbEsuLK3EOMEhzMSiK85zOAQrwpiZVVqUX58UWlOanF hxiZODilGhg3uO9ol30363dl3LQMzQ13HY9LeBreyN+U/mjaocw3NtszardeTEpXE+nfov2p 1p4zRuvfnar162VXhbrHpNydJKLFaWeQ8WxGgaBN6LeMpzIH7jnv5jfszzOeM+/mk65GoygV 1fOR2o+N7guYvn3P/vGw9TOBMw4+tYWtFw+Gvwmdd1Xm0zUlluKMREMt5qLiRACeO/uEQAIA AA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 27/02/15 05:34, Axel Lin wrote: > If IS_ERR(state->regs) the .probe fails. > So IS_ERR(state->regs) test in exynos_dp_video_phy_pwr_isol() is not necessary. > exynos_dp_video_phy_pwr_isol() simply does a regmap_update_bits() call now, > just call regmap_update_bits() instead and return proper return value. > > Signed-off-by: Axel Lin Reviewed-by: Sylwester Nawrocki