public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Richard Weinberger <richard@nod.at>
To: DaeSeok Youn <daeseok.youn@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	mfasheh@suse.com, Joel Becker <jlbec@evilplan.org>,
	"ocfs2-devel@oss.oracle.com" <ocfs2-devel@oss.oracle.com>,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/3] ocfs2: remove unneeded variable 'status'
Date: Sat, 28 Feb 2015 07:55:19 +0100	[thread overview]
Message-ID: <54F16657.4000800@nod.at> (raw)
In-Reply-To: <CAHb8M2CkVZxJQ_aD7sq4B5UjL6ewgCa4YTW0jjbGyvXN+eeYPg@mail.gmail.com>

Am 27.02.2015 um 11:29 schrieb DaeSeok Youn:
> Hi,
> 
> 2015-02-27 18:41 GMT+09:00 Richard Weinberger <richard.weinberger@gmail.com>:
>> On Fri, Feb 27, 2015 at 10:27 AM, DaeSeok Youn <daeseok.youn@gmail.com> wrote:
>>> Hi,
>>>
>>> I think this patch was already queued. Can I send this patch again
>>> after update changelog?
>>
>> One thing that is much more important, how did you test this patch? Did you?
> 
> I couldn't test, actually I don't have the environment for testing
> this file system.
> just looking this file for cleaning up and found this.

*please* setup a test environment and test the code paths you're changing.

Thanks,
//richard

      reply	other threads:[~2015-02-28  6:55 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-23 10:38 [PATCH 1/3] ocfs2: remove unneeded variable 'status' Daeseok Youn
2015-02-26 21:33 ` Andrew Morton
2015-02-27  9:27   ` DaeSeok Youn
2015-02-27  9:41     ` Richard Weinberger
2015-02-27 10:29       ` DaeSeok Youn
2015-02-28  6:55         ` Richard Weinberger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54F16657.4000800@nod.at \
    --to=richard@nod.at \
    --cc=akpm@linux-foundation.org \
    --cc=daeseok.youn@gmail.com \
    --cc=jlbec@evilplan.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mfasheh@suse.com \
    --cc=ocfs2-devel@oss.oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox