From: Arjan van de Ven <arjan@linux.intel.com>
To: jesse.brandeburg@intel.com, mingo@kernel.org,
linux-kernel@vger.kernel.org, ast@plumgrid.com,
daniel@iogearbox.net, bruce.w.allan@intel.com, hpa@zytor.com,
tglx@linutronix.de, bp@suse.de,
linux-tip-commits@vger.kernel.org
Subject: Re: [tip:x86/mm] x86/mm: Unexport set_memory_ro() and set_memory_rw()
Date: Sat, 28 Feb 2015 04:53:56 -0800 [thread overview]
Message-ID: <54F1BA64.3020000@linux.intel.com> (raw)
In-Reply-To: <tip-6bbb614ec478961c7443086bdf7fd6784479c14a@git.kernel.org>
On 2/28/2015 2:00 AM, tip-bot for Daniel Borkmann wrote:
> Commit-ID: 6bbb614ec478961c7443086bdf7fd6784479c14a
> Gitweb: http://git.kernel.org/tip/6bbb614ec478961c7443086bdf7fd6784479c14a
> Author: Daniel Borkmann <daniel@iogearbox.net>
> AuthorDate: Fri, 27 Feb 2015 15:55:40 +0100
> Committer: Ingo Molnar <mingo@kernel.org>
> CommitDate: Sat, 28 Feb 2015 10:41:59 +0100
>
> x86/mm: Unexport set_memory_ro() and set_memory_rw()
>
> This effectively unexports set_memory_ro() and set_memory_rw()
> functions, and thus reverts:
>
> a03352d2c1dc ("x86: export set_memory_ro and set_memory_rw").
>
> They have been introduced for debugging purposes in e1000e, but
> no module user is in mainline kernel (anymore?) and we
> explicitly do not want modules to use these functions, as they
> i.e. protect eBPF (interpreted & JIT'ed) images from malicious
> modifications or bugs.
>
> Outside of eBPF scope, I believe also other set_memory_*()
> functions should be unexported on x86 for modules.
>
Acked-by: Arjan van de Ven <arjan@linux.intel.com>
next prev parent reply other threads:[~2015-02-28 12:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1425040939.git.daniel@iogearbox.net>
2015-02-27 14:55 ` [PATCH net-next 08/10] x86: unexport set_memory_ro and set_memory_rw Daniel Borkmann
2015-02-28 10:00 ` [tip:x86/mm] x86/mm: Unexport set_memory_ro() and set_memory_rw() tip-bot for Daniel Borkmann
2015-02-28 12:53 ` Arjan van de Ven [this message]
2015-02-27 14:55 ` [PATCH net-next 09/10] arm64: unexport set_memory_ro and set_memory_rw Daniel Borkmann
2015-02-27 18:51 ` Laura Abbott
2015-02-27 19:54 ` Will Deacon
2015-02-27 20:05 ` Daniel Borkmann
2015-03-01 9:52 ` Daniel Borkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54F1BA64.3020000@linux.intel.com \
--to=arjan@linux.intel.com \
--cc=ast@plumgrid.com \
--cc=bp@suse.de \
--cc=bruce.w.allan@intel.com \
--cc=daniel@iogearbox.net \
--cc=hpa@zytor.com \
--cc=jesse.brandeburg@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox