From: Lino Sanfilippo <LinoSanfilippo@gmx.de>
To: "Suzuki K. Poulose" <suzuki.poulose@arm.com>
Cc: linux-kernel@vger.kernel.org, Jan Kara <jack@suse.cz>,
Eric Paris <eparis@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
Will Deacon <will.deacon@arm.com>
Subject: Re: [PATCH] fanotify: Fix event filtering with FAN_ONDIR set
Date: Sun, 01 Mar 2015 03:31:02 +0100 [thread overview]
Message-ID: <54F279E6.90307@gmx.de> (raw)
In-Reply-To: <1425037239-18881-1-git-send-email-suzuki.poulose@arm.com>
Hi Suzuki,
On 27.02.2015 12:40, Suzuki K. Poulose wrote:
> From: "Suzuki K. Poulose" <suzuki.poulose@arm.com>
>
> With FAN_ONDIR set, the user can end up getting events, which
> it hasn't marked. This was revealed with fanotify04 testcase
> failure on Linux-4.0-rc1, and is a regression from 3.19, revealed
> with commit (66ba93c0d7fe6: fanotify: don't set FAN_ONDIR implicitly
> on a marks ignored mask).
>
>
> Fix this by masking the outgoing events to the user, as we
> already take care of FAN_ONDIR and FAN_EVENT_ON_CHILD.
>
thank you for fixing this. I tested your solution and it works, so you
can add Tested-by: Lino Sanfilippo <LinoSanfilippo@gmx.de>.
Regards,
Lino
next prev parent reply other threads:[~2015-03-01 2:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-27 11:40 [PATCH] fanotify: Fix event filtering with FAN_ONDIR set Suzuki K. Poulose
2015-03-01 2:31 ` Lino Sanfilippo [this message]
2015-03-02 10:38 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54F279E6.90307@gmx.de \
--to=linosanfilippo@gmx.de \
--cc=akpm@linux-foundation.org \
--cc=eparis@redhat.com \
--cc=jack@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=suzuki.poulose@arm.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox