From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752627AbbCAR7U (ORCPT <rfc822;w@1wt.eu>);
	Sun, 1 Mar 2015 12:59:20 -0500
Received: from mail-la0-f44.google.com ([209.85.215.44]:38114 "EHLO
	mail-la0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751752AbbCAR7P (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Sun, 1 Mar 2015 12:59:15 -0500
Message-ID: <54F35371.7020608@cogentembedded.com>
Date: Sun, 01 Mar 2015 20:59:13 +0300
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0
MIME-Version: 1.0
To: Roman Volkov <rvolkov@v1ros.org>, Rob Herring <robh+dt@kernel.org>,
        Pawel Moll <pawel.moll@arm.com>, Mark Rutland <mark.rutland@arm.com>,
        Ian Campbell <ijc+devicetree@hellion.org.uk>,
        Kumar Gala <galak@codeaurora.org>,
        Russell King <linux@arm.linux.org.uk>
CC: devicetree@vger.kernel.org, Alexey Charkov <alchark@gmail.com>,
        linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 1/2] dts: vt8500: Add SDHC node to DTS file for WM8650
References: <1423130878-3894-1-git-send-email-v1ron@v1ros.org> <1425226007-2757-1-git-send-email-rvolkov@v1ros.org> <1425226007-2757-2-git-send-email-rvolkov@v1ros.org>
In-Reply-To: <1425226007-2757-2-git-send-email-rvolkov@v1ros.org>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 3/1/2015 7:06 PM, Roman Volkov wrote:

> Since WM8650 has the same 'WMT' SDHC controller as WM8505, and the driver
> is already in the kernel, this node enables the controller support for
> WM8650

> Signed-off-by: Roman Volkov <rvolkov@v1ros.org>
> Reviewed-by: Alexey Charkov <alchark@gmail.com>
> ---
>   arch/arm/boot/dts/wm8650.dtsi | 9 +++++++++
>   1 file changed, 9 insertions(+)

> diff --git a/arch/arm/boot/dts/wm8650.dtsi b/arch/arm/boot/dts/wm8650.dtsi
> index b1c59a7..e12213d 100644
> --- a/arch/arm/boot/dts/wm8650.dtsi
> +++ b/arch/arm/boot/dts/wm8650.dtsi
> @@ -187,6 +187,15 @@
>   			interrupts = <43>;
>   		};
>
> +		sdhc@d800a000 {

    According to the ePAPR standard, the device nodes should have generic 
names according to their functions, so this node should be named just 
"sd@d800a000".

WBR, Sergei