From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752933AbbCASEv (ORCPT ); Sun, 1 Mar 2015 13:04:51 -0500 Received: from mail-we0-f174.google.com ([74.125.82.174]:34267 "EHLO mail-we0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751877AbbCASEt (ORCPT ); Sun, 1 Mar 2015 13:04:49 -0500 Message-ID: <54F354B7.9020402@gmail.com> Date: Sun, 01 Mar 2015 20:04:39 +0200 From: Nikolai Kondrashov User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.4.0 MIME-Version: 1.0 To: Benjamin Tissoires , Jiri Kosina CC: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, DIGImend-devel Subject: Re: [PATCH v2 3/6] HID: uclogic: name the input nodes based on their tool References: <1424977049-18648-1-git-send-email-benjamin.tissoires@redhat.com> <1424977049-18648-4-git-send-email-benjamin.tissoires@redhat.com> In-Reply-To: <1424977049-18648-4-git-send-email-benjamin.tissoires@redhat.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/26/2015 08:57 PM, Benjamin Tissoires wrote: > We append "Pen", "Pad", "Mouse", "Keyboard", "Consumer Control" or > "System Control" suffix to the appropriate input node to match what > the Wacom driver does and be more convenient for the user to know > which one is which. > > Signed-off-by: Benjamin Tissoires I read the kernel code and tested this a little. This looks and works fine. Reviewed-by: Nikolai Kondrashov