From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752933AbbCBABE (ORCPT ); Sun, 1 Mar 2015 19:01:04 -0500 Received: from mailout2.samsung.com ([203.254.224.25]:54511 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751313AbbCBAA7 (ORCPT ); Sun, 1 Mar 2015 19:00:59 -0500 X-AuditID: cbfee690-f79ab6d0000046f7-85-54f3a83732da Message-id: <54F3A837.3030002@samsung.com> Date: Mon, 02 Mar 2015 09:00:55 +0900 From: Beomho Seo User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-version: 1.0 To: Paul Bolle , Jaewon Kim Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-pm@vger.kernel.org, linux-input@vger.kernel.org, Inki Dae , SangBae Lee , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Lee Jones , Chanwoo Choi , Sebastian Reichel , Dmitry Torokhov , beomho.seo@samsung.com Subject: Re: [PATCH v6 3/5] power: max77843_battery: Add Max77843 fuel gauge device driver References: <1424741348-8728-1-git-send-email-jaewon02.kim@samsung.com> <1424741348-8728-4-git-send-email-jaewon02.kim@samsung.com> <1425153626.24292.62.camel@x220> In-reply-to: <1425153626.24292.62.camel@x220> Content-type: text/plain; charset=utf-8 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrLIsWRmVeSWpSXmKPExsWyRsSkUNd8xecQg/MfLSxOf9rGbnH9y3NW i/lHzrFaHF70gtGi/81CVotzr1YyWky6P4HFYkfDEVaL+1+PMlrc/PSN1eLyrjlsFp97jzBa LL1+kcliwvS1LBaLbp1htmjde4Td4vingywWp3eXOAh5rJm3htHjcl8vk8fOWXfZPVYu/8Lm sWlVJ5vHnWt72Dz6tqxi9Ni4/QmTx+dNcgGcUVw2Kak5mWWpRfp2CVwZW+4sYi3oE6z48WAl ewPjFt4uRk4OCQETiYZNX5khbDGJC/fWs3UxcnEICSxllLi9+z0rTNHTO9eYIBKLGCXm/lgP 5bxmlJgwfwIjSBWvgJbE3Q9HwUaxCKhKzJvSzgRiswloSryfcoUFxBYViJCYf+w1M0S9oMSP yffA4iICXhKbD5xgB7GZBbazSCy+5A5iCwvESDy9+RHqpBWMEsd+zQBbximgK7Gj6yRQggOo QV1iypRciF55ic1r3jKD1EsI7OGQWP11GtRBAhLfJh9iAamXEJCV2HQA6mVJiYMrbrBMYBSb heSkWQhTZyGZuoCReRWjaGpBckFxUnqRiV5xYm5xaV66XnJ+7iZGYCo4/e/ZhB2M9w5YH2IU 4GBU4uH1mPM5RIg1say4MvcQoynQEROZpUST84EJJ68k3tDYzMjC1MTU2Mjc0kxJnPe11M9g IYH0xJLU7NTUgtSi+KLSnNTiQ4xMHJxSDYyh26U4GbTd6nZe3TDlhfPXmmOr7ga4+XtFsW32 6asrne/C/2WGkGh7H8PWiJKHMn2v7ulIl9m1Hw65eV/u9R/VXxtvzj/wfErFbsayng97VTle x6R1O9hMX73rd2I8+wrRTGZTLeV3am7+QUFfb+nNF1n3J3X77YC/nDxvC4PZwr1vL8lOMFVi Kc5INNRiLipOBABWNOjLAAMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrOKsWRmVeSWpSXmKPExsVy+t9jAV3zFZ9DDJZP07c4/Wkbu8X1L89Z LeYfOcdqcXjRC0aL/jcLWS3OvVrJaDHp/gQWix0NR1gt7n89ymhx89M3VovLu+awWXzuPcJo sfT6RSaLCdPXslgsunWG2aJ17xF2i+OfDrJYnN5d4iDksWbeGkaPy329TB47Z91l91i5/Aub x6ZVnWwed67tYfPo27KK0WPj9idMHp83yQVwRjUw2mSkJqakFimk5iXnp2TmpdsqeQfHO8eb mhkY6hpaWpgrKeQl5qbaKrn4BOi6ZeYAfaSkUJaYUwoUCkgsLlbSt8M0ITTETdcCpjFC1zck CK7HyAANJKxhzNhyZxFrQZ9gxY8HK9kbGLfwdjFyckgImEg8vXONCcIWk7hwbz1bFyMXh5DA IkaJuT/WM0E4rxklJsyfwAhSxSugJXH3w1FmEJtFQFVi3pR2sG42AU2J91OusIDYogIREvOP vWaGqBeU+DH5HlhcRMBLYvOBE+wgNrPAdhaJxZfcQWxhgRiJpzc/Qm1ewShx7NcMsGWcAroS O7pOAiU4gBrUJaZMyYXolZfYvOYt8wRGgVlIVsxCqJqFpGoBI/MqRtHUguSC4qT0XEO94sTc 4tK8dL3k/NxNjOBE80xqB+PKBotDjAIcjEo8vB5zPocIsSaWFVfmHmKU4GBWEuE9UwgU4k1J rKxKLcqPLyrNSS0+xGgKDICJzFKiyfnAJJhXEm9obGJmZGlkbmhhZGyuJM6rZN8WIiSQnliS mp2aWpBaBNPHxMEp1cAYwTXP3+hm2XJNFSOGubNnzZ8QrvxxYaFlR+d/1ts3Ehz+i/1JTN92 Sos5Tv95XYbT7F3P0rNnmm74s8HtzYyk+YuMlsdGS8idZf9U+MPK9f5H49cLp//lPn79zp7H 1ydWNiht/JbDXRnZnMTM1bJXe8Lrwn16K+q2cZSumH/o/t4FhvwTT/0tUWIpzkg01GIuKk4E AL5yLJhKAwAA DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/01/2015 05:00 AM, Paul Bolle wrote: > On Tue, 2015-02-24 at 10:29 +0900, Jaewon Kim wrote: >> diff --git a/drivers/power/Kconfig b/drivers/power/Kconfig >> index 994793d..555e436 100644 >> --- a/drivers/power/Kconfig >> +++ b/drivers/power/Kconfig >> @@ -212,6 +212,15 @@ config BATTERY_MAX17042 >> with MAX17042. This driver also supports max17047/50 chips which are >> improved version of max17042. >> >> +config BATTERY_MAX77843 >> + tristate "Maxim MAX77843 Fuel Gauge" >> + depends on MFD_MAX77843 >> + help >> + This adds support for battery fuel gauge in Maxim MAX77843. It is >> + fuel-gauge for a lithium-ion batteries with a single cell and can be >> + found in portable devices. The MAX17040 is configured to operate with > > Could MAX17040 be a copy/paste error? > >> + a single lithium cell. >> + >> config BATTERY_Z2 >> tristate "Z2 battery driver" >> depends on I2C && MACH_ZIPIT2 > > [...] > >> diff --git a/drivers/power/max77843_battery.c b/drivers/power/max77843_battery.c >> new file mode 100644 >> index 0000000..0c59a16 >> --- /dev/null >> +++ b/drivers/power/max77843_battery.c >> @@ -0,0 +1,286 @@ >> +/* >> + * Fuel gauge driver for Maxim MAX77843 >> + * >> + * Copyright (C) 2015 Samsung Electronics, Co., Ltd. >> + * Author: Beomho Seo >> + * >> + * This program is free software; you can redistribute it and/or modify >> + * it under the terms of the GNU General Public License version 2 as >> + * published bythe Free Software Foundation. >> + */ > > I did > git grep "bythe Free" next-20150227 > > and it returned five hits. This would be the sixth. > > Anyhow, this states that this file is licensed GPL v2. > > [...] > >> +MODULE_LICENSE("GPL"); > > So this should probably be > MODULE_LICENSE("GPL v2"); > > > Paul Bolle > Thank you for your review. I will fix next revision. Thanks, Beomho Seo > -- > To unsubscribe from this list: send the line "unsubscribe linux-input" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >