Re: [PATCH v6 2/5] power: max77843_charger: Add Max77843 charger device driver

Beomho Seo
2015-03-02T00:05:25Z

On 03/01/2015 05:03 AM, Paul Bolle wrote:
> On Tue, 2015-02-24 at 10:29 +0900, Jaewon Kim wrote:
>> diff --git a/drivers/power/max77843_charger.c b/drivers/power/max77843_charger.c
>> new file mode 100644
>> index 0000000..392eebc1a
>> --- /dev/null
>> +++ b/drivers/power/max77843_charger.c
>> @@ -0,0 +1,508 @@
>> +/*
>> + * Charger driver for Maxim MAX77843
>> + *
>> + * Copyright (C) 2015 Samsung Electronics, Co., Ltd.
>> + * Author: Beomho Seo <beomho.seo@samsung.com>
>> + *
>> + * This program is free software; you can redistribute it and/or modify
>> + * it under the terms of the GNU General Public License version 2 as
>> + * published bythe Free Software Foundation.
>
> There's "bythe" again.
>
>> + */
>
> [...]
>

OK, I will add spacer.

>> +MODULE_LICENSE("GPL");
>
> And that should probably be
> MODULE_LICENSE("GPL v2");
>
>
> Paul Bolle
>
>

OK, I will change license.
Thank you for your review.

Thanks,
Beomho Seo