From: Beomho Seo <beomho.seo@samsung.com>
To: Paul Bolle <pebolle@tiscali.nl>, Jaewon Kim <jaewon02.kim@samsung.com>
Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-pm@vger.kernel.org, linux-input@vger.kernel.org,
Inki Dae <inki.dae@samsung.com>,
SangBae Lee <sangbae90.lee@samsung.com>,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Lee Jones <lee.jones@linaro.org>,
Chanwoo Choi <cw00.choi@samsung.com>,
Sebastian Reichel <sre@kernel.org>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
beomho.seo@samsung.com
Subject: Re: [PATCH v6 2/5] power: max77843_charger: Add Max77843 charger device driver
Date: Mon, 02 Mar 2015 09:05:19 +0900 [thread overview]
Message-ID: <54F3A93F.3050609@samsung.com> (raw)
In-Reply-To: <1425153821.24292.65.camel@x220>
On 03/01/2015 05:03 AM, Paul Bolle wrote:
> On Tue, 2015-02-24 at 10:29 +0900, Jaewon Kim wrote:
>> diff --git a/drivers/power/max77843_charger.c b/drivers/power/max77843_charger.c
>> new file mode 100644
>> index 0000000..392eebc1a
>> --- /dev/null
>> +++ b/drivers/power/max77843_charger.c
>> @@ -0,0 +1,508 @@
>> +/*
>> + * Charger driver for Maxim MAX77843
>> + *
>> + * Copyright (C) 2015 Samsung Electronics, Co., Ltd.
>> + * Author: Beomho Seo <beomho.seo@samsung.com>
>> + *
>> + * This program is free software; you can redistribute it and/or modify
>> + * it under the terms of the GNU General Public License version 2 as
>> + * published bythe Free Software Foundation.
>
> There's "bythe" again.
>
>> + */
>
> [...]
>
OK, I will add spacer.
>> +MODULE_LICENSE("GPL");
>
> And that should probably be
> MODULE_LICENSE("GPL v2");
>
>
> Paul Bolle
>
>
OK, I will change license.
Thank you for your review.
Thanks,
Beomho Seo
next prev parent reply other threads:[~2015-03-02 0:05 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-24 1:29 [PATCH v6 0/5] Add new MFD driver for MAX77843 Jaewon Kim
2015-02-24 1:29 ` [PATCH v6 1/5] mfd: max77843: Add max77843 MFD driver core driver Jaewon Kim
2015-02-25 16:47 ` Lee Jones
2015-02-26 2:58 ` Jaewon Kim
2015-02-24 1:29 ` [PATCH v6 2/5] power: max77843_charger: Add Max77843 charger device driver Jaewon Kim
2015-02-28 20:03 ` Paul Bolle
2015-03-02 0:05 ` Beomho Seo [this message]
2015-02-24 1:29 ` [PATCH v6 3/5] power: max77843_battery: Add Max77843 fuel gauge " Jaewon Kim
2015-02-28 20:00 ` Paul Bolle
2015-03-02 0:00 ` Beomho Seo
2015-02-24 1:29 ` [PATCH v6 4/5] Input: add haptic drvier on max77843 Jaewon Kim
2015-02-26 1:23 ` Dmitry Torokhov
2015-02-26 2:49 ` Jaewon Kim
2015-02-27 17:49 ` Dmitry Torokhov
2015-03-02 6:08 ` Jaewon Kim
2015-02-24 1:29 ` [PATCH v6 5/5] Documentation: Add device tree bindings document for max77843 Jaewon Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54F3A93F.3050609@samsung.com \
--to=beomho.seo@samsung.com \
--cc=cw00.choi@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=inki.dae@samsung.com \
--cc=jaewon02.kim@samsung.com \
--cc=lee.jones@linaro.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=pebolle@tiscali.nl \
--cc=robh+dt@kernel.org \
--cc=sangbae90.lee@samsung.com \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox