From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753391AbbCBAFZ (ORCPT ); Sun, 1 Mar 2015 19:05:25 -0500 Received: from mailout4.samsung.com ([203.254.224.34]:29689 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751313AbbCBAFW (ORCPT ); Sun, 1 Mar 2015 19:05:22 -0500 X-AuditID: cbfee691-f79b86d000004a5a-be-54f3a9404a96 Message-id: <54F3A93F.3050609@samsung.com> Date: Mon, 02 Mar 2015 09:05:19 +0900 From: Beomho Seo User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-version: 1.0 To: Paul Bolle , Jaewon Kim Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-pm@vger.kernel.org, linux-input@vger.kernel.org, Inki Dae , SangBae Lee , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Lee Jones , Chanwoo Choi , Sebastian Reichel , Dmitry Torokhov , beomho.seo@samsung.com Subject: Re: [PATCH v6 2/5] power: max77843_charger: Add Max77843 charger device driver References: <1424741348-8728-1-git-send-email-jaewon02.kim@samsung.com> <1424741348-8728-3-git-send-email-jaewon02.kim@samsung.com> <1425153821.24292.65.camel@x220> In-reply-to: <1425153821.24292.65.camel@x220> Content-type: text/plain; charset=utf-8 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrLIsWRmVeSWpSXmKPExsWyRsSkWNdh5ecQg7mr5S1Of9rGbnH9y3NW i/lHzrFaHF70gtGi/81CVotzr1YyWky6P4HFYkfDEVaL+1+PMlrc/PSN1eLyrjlsFp97jzBa LL1+kcliwvS1LBaLbp1htmjde4Td4vingywWp3eXOAh5rJm3htHjcl8vk8fOWXfZPVYu/8Lm sWlVJ5vHnWt72Dz6tqxi9Ni4/QmTx+dNcgGcUVw2Kak5mWWpRfp2CVwZ71bvYS94zF4x7cJO lgbGFrYuRk4OCQETicNN65khbDGJC/fWA8W5OIQEljJKPJzxlwWmaNvL66wQiUWMEn1d+1kg nNeMEr3nj4GN4hXQkug6e5URxGYRUJV4evsLWDebgKbE+ylXwGxRgQiJ+cdeM0PUC0r8mHwP LC4i4CWx+cAJdhCbWWA7i8TiS+4gtrBApMTk1behNq9glPh2cgorSIJTQFdi0e0JQMs4gBrU JaZMyYXolZfYvOYtM0i9hMAeDonm5m42iIMEJL5NPsQCUi8hICux6QDUy5ISB1fcYJnAKDYL yUmzEKbOQjJ1ASPzKkbR1ILkguKk9CJTveLE3OLSvHS95PzcTYzAVHD637OJOxjvH7A+xCjA wajEw7tg3ucQIdbEsuLK3EOMpkBHTGSWEk3OByacvJJ4Q2MzIwtTE1NjI3NLMyVxXh3pn8FC AumJJanZqakFqUXxRaU5qcWHGJk4OKUaGDudDRjnr5nNrKd09lUY/wO+nVvW2vTUrFg+5VV+ /VNVsUcr7xpVcJzJ770ksutlp+aGzusHP731uXbt8YSKd0LGrsyqG1506R57cDeyp07+nMXx 96Z+Rc/D455wHPIt873xuz4yX99nHeuMzKdVPsGRJTVfC9vl0o+scMjQeqTIOt/nMrv6fyWW 4oxEQy3mouJEAFJWK0EAAwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrOKsWRmVeSWpSXmKPExsVy+t9jAV2HlZ9DDC5dEbU4/Wkbu8X1L89Z LeYfOcdqcXjRC0aL/jcLWS3OvVrJaDHp/gQWix0NR1gt7n89ymhx89M3VovLu+awWXzuPcJo sfT6RSaLCdPXslgsunWG2aJ17xF2i+OfDrJYnN5d4iDksWbeGkaPy329TB47Z91l91i5/Aub x6ZVnWwed67tYfPo27KK0WPj9idMHp83yQVwRjUw2mSkJqakFimk5iXnp2TmpdsqeQfHO8eb mhkY6hpaWpgrKeQl5qbaKrn4BOi6ZeYAfaSkUJaYUwoUCkgsLlbSt8M0ITTETdcCpjFC1zck CK7HyAANJKxhzHi3eg97wWP2imkXdrI0MLawdTFyckgImEhse3mdFcIWk7hwbz1QnItDSGAR o0Rf134WCOc1o0Tv+WNgHbwCWhJdZ68ygtgsAqoST29/YQGx2QQ0Jd5PuQJmiwpESMw/9poZ ol5Q4sfke2BxEQEvic0HTrCD2MwC21kkFl9yB7GFBSIlJq++zQqxbAWjxLeTU8BO4hTQlVh0 ewLQMg6gBnWJKVNyIXrlJTavecs8gVFgFpIVsxCqZiGpWsDIvIpRNLUguaA4KT3XSK84Mbe4 NC9dLzk/dxMjONE8k97BuKrB4hCjAAejEg+vx5zPIUKsiWXFlbmHGCU4mJVEeM8UAoV4UxIr q1KL8uOLSnNSiw8xmgIDYCKzlGhyPjAJ5pXEGxqbmBlZGpkbWhgZmyuJ8yrZt4UICaQnlqRm p6YWpBbB9DFxcEo1MC7IZJKUjznee7xixoIddR92JJ5yNNAOfXBn9reNJZsVzSOPP4ru/hJl //zJqV92t6/9XVN9nIPxJtc6c+7rphzsm8XXX2T7t/LDng1PDzocr+9VuHb5+bG1wdlMZX05 Rlb877LyLUU/G0+zmWz0QeTQSQce+Q8+poJi7as8wkX3KH41+5WwzkuJpTgj0VCLuag4EQAq wZluSgMAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/01/2015 05:03 AM, Paul Bolle wrote: > On Tue, 2015-02-24 at 10:29 +0900, Jaewon Kim wrote: >> diff --git a/drivers/power/max77843_charger.c b/drivers/power/max77843_charger.c >> new file mode 100644 >> index 0000000..392eebc1a >> --- /dev/null >> +++ b/drivers/power/max77843_charger.c >> @@ -0,0 +1,508 @@ >> +/* >> + * Charger driver for Maxim MAX77843 >> + * >> + * Copyright (C) 2015 Samsung Electronics, Co., Ltd. >> + * Author: Beomho Seo >> + * >> + * This program is free software; you can redistribute it and/or modify >> + * it under the terms of the GNU General Public License version 2 as >> + * published bythe Free Software Foundation. > > There's "bythe" again. > >> + */ > > [...] > OK, I will add spacer. >> +MODULE_LICENSE("GPL"); > > And that should probably be > MODULE_LICENSE("GPL v2"); > > > Paul Bolle > > OK, I will change license. Thank you for your review. Thanks, Beomho Seo